Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Fix]: When destroying, failed to remove the dragover and dragenter events.#2373

Open
KonghaYao wants to merge 6 commits into
SortableJS:masterSortableJS/Sortable:masterfrom
KonghaYao:masterKonghaYao/Sortable:masterCopy head branch name to clipboard
Open

[Fix]: When destroying, failed to remove the dragover and dragenter events.#2373
KonghaYao wants to merge 6 commits into
SortableJS:masterSortableJS/Sortable:masterfrom
KonghaYao:masterKonghaYao/Sortable:masterCopy head branch name to clipboard

Conversation

@KonghaYao

Copy link
Copy Markdown

When I repeated the destroy and mount events, I found that the dragover and dragenter events mounted by Sortablejs were not destroyed, which caused a bug. So I checked the source code and fixed the issue.

@KonghaYao

Copy link
Copy Markdown
Author

image
It looks like the tests on circleCI failed, but they were successful on my device. Windows 10.

@KonghaYao

Copy link
Copy Markdown
Author

Because there was an error in the CircleCI pipeline, I upgraded testcafe and its related configurations directly so that it can run test scripts for everyone.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.