Irina/sonarjava 4396#4317
Merged
irina-batinic-sonarsource merged 23 commits intoMar 1, 2023
Merged
Irina/sonarjava 4396#4317
Conversation
…ing from the cache. All steps before checks are passing.
95f4778 to
0cb2024
Compare
dorian-burihabwa-sonarsource
requested changes
Mar 1, 2023
dorian-burihabwa-sonarsource
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the great work, I think there is some fine-tuning needed so that we align with the other analyzers but we are almost there
Comment on lines
+491
to
+496
| if (!inputFile.status().equals(InputFile.Status.SAME)) { | ||
| LOG.trace("File status is: " + inputFile.status() + ". File can be skipped."); | ||
| contentHashCache.writeToCache(inputFile); | ||
| return false; | ||
| } | ||
| return canSkipInContext && inputFile.status() == InputFile.Status.SAME; | ||
| return contentHashCache.hasSameHashCached(inputFile); |
Contributor
There was a problem hiding this comment.
It looks like we are taking a shortcut by checking the status before checking the cache. My understanding is that we should check the cache, and if the cache is disabled, check the status. WDYT?
dorian-burihabwa-sonarsource
requested changes
Mar 1, 2023
dorian-burihabwa-sonarsource
left a comment
Contributor
There was a problem hiding this comment.
Nice job on the fixes, I think that should be the last round of ping-pong. Feel free to test the logs in the ContehHashCacheTest tests if you feel it makes sense
dorian-burihabwa-sonarsource
approved these changes
Mar 1, 2023
dorian-burihabwa-sonarsource
left a comment
Contributor
There was a problem hiding this comment.
LGTM 👍🏿
|
SonarQube Quality Gate
|
100.0% reviewed)
irina-batinic-sonarsource
added a commit
that referenced
this pull request
Mar 6, 2023
irina-batinic-sonarsource
added a commit
that referenced
this pull request
Mar 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.