SONARJAVA-3173 Update metadata#2630
Merged
Merged
SONARJAVA-3173 Update metadata#2630
Conversation
ghost
commented
Jul 31, 2019
| <pre> | ||
| if ( (myFirstCondition() || mySecondCondition()) && myLastCondition()) { ... } | ||
| </pre> | ||
| <h2>Exceptions</h2> |
| </ul> | ||
| <h2>Deprecated</h2> | ||
| <p>This rule is deprecated; use {rule:squid:S4790} instead.</p> | ||
| <p>This rule is deprecated; use {rule:squid:S4790}, {rule:squid:S5344} instead.</p> |
|
|
||
| slf4jLog.debug(marker, "message {}", 1); | ||
|
|
||
| org.apache.logging.log4j.Logger log4jLog; |
| slf4jLog.debug(marker, "message {}"); | ||
| slf4jLog.debug(marker, "message {}", 1); | ||
|
|
||
| org.apache.logging.log4j.Logger log4jLog; |
| </pre> | ||
| <h2>Exceptions</h2> | ||
| <p>No issue is reported when the parameter is annotated with <code>@PathVariable</code> from Spring Framework, since the lookup will be done via id, | ||
| the object cannot be forged on client side.</p> |
alban-auzeill
requested changes
Aug 2, 2019
| } | ||
| } | ||
| </pre> | ||
| <h2>Questionable Code Example</h2> |
Member
There was a problem hiding this comment.
This long Questionable Code Example section is duplicated, rule-api should be drunk.
I'm going to change Questionable Code Example by Sensitive Code Example in the RSPEC, it should fix rule-api.
alban-auzeill
approved these changes
Aug 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.