Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

SONARJAVA-2834 Update messages in security hotspot rules#2126

Merged
saberduck merged 3 commits into
masterSonarSource/sonar-java:masterfrom
SONARJAVA-2834SonarSource/sonar-java:SONARJAVA-2834Copy head branch name to clipboard
Jul 26, 2018
Merged

SONARJAVA-2834 Update messages in security hotspot rules#2126
saberduck merged 3 commits into
masterSonarSource/sonar-java:masterfrom
SONARJAVA-2834SonarSource/sonar-java:SONARJAVA-2834Copy head branch name to clipboard

Conversation

@saberduck

Copy link
Copy Markdown
Contributor

No description provided.

@agigleux

Copy link
Copy Markdown
Member

I can't accept this PR. The .htlm files for Hotspot rules are not compliant with what is inside RSPEC. A WARN was raised during the generation of the json/html files, we thought it was just a WARN but actually it's not generating the content of RSPEC.

@saberduck

Copy link
Copy Markdown
Contributor Author

@agigleux I updated the metadata with new rule-api

@agigleux agigleux left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saberduck saberduck merged commit b7e2259 into master Jul 26, 2018
@saberduck saberduck deleted the SONARJAVA-2834 branch July 26, 2018 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.