Mitigate issue where outline thicknesses less than 0.5 fail out generate solid shapes not outlines - #324
#324Merged
Merged
Mitigate issue where outline thicknesses less than 0.5 fail out generate solid shapes not outlines#324
Conversation
if the outline thickness is going to trigger the noop behaviour of the clipper then scale the inout and output to no trigger that behaviour.
| IEnumerable<ISimplePath> paths = path.Flatten(); | ||
| width = CalculateScalingMatrix(width, out Matrix3x2 scaleUpMartrix, out Matrix3x2 scaleDownMartrix); | ||
|
|
||
| IEnumerable<ISimplePath> paths = path.Transform(scaleUpMartrix).Flatten(); |
Member
There was a problem hiding this comment.
Shouldn't we only do this if the path is < .5f? It seems like we're adding overhead to all outline generation now.
Member
Author
There was a problem hiding this comment.
Transform(...) is a no op (returning the original IPath) for Matrix3x2.Identity which will be return for sizes >= 0.5.
Member
There was a problem hiding this comment.
Ah... Missed that. Looks good.
I'm hoping that once I get the new path stoker wired up this issue will go away.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
If the outline thickness is going to trigger the noop behaviour of the clipper then scale the inputs and outputs to not trigger that behaviour.
I tried just removing the test in
PolygonOffsetter.csbut for some reason that causes very small outlines to take significantly longer to generate than scaling up and down. (not investigated why).This causes everything to generally render now, what it renders at particularly small sizes might not be the best (not investigated) but at least we generally render something better than the solid shape.
resolves #323