Remove compiler conditions - #288
#288Merged
Merged
Remove compiler conditions#288
Conversation
| if (this.groupList.Count == 0) | ||
| { | ||
| goto Error; | ||
| return; |
Member
Author
There was a problem hiding this comment.
I spotted this when trying to run a benchmark. I'd deviated from clippers default behavior for some reason.
| // Copyright (c) Six Labors. | ||
| // Licensed under the Six Labors Split License. | ||
|
|
||
| using System.Numerics; |
Member
Author
There was a problem hiding this comment.
@antonfirsov I spotted this comment. Are we able to replace this code with built in APIs now?
// Adapted from:
// https://github.com/dotnet/runtime/blob/master/src/libraries/System.Private.CoreLib/src/System/Collections/Generic/ArraySortHelper.cs
// If targeting .NET 5, we can call span based sort, but probably not worth it only for that API.
Member
There was a problem hiding this comment.
Yes, we can now delete SortUtility and use span.Sort(...) overloads instead in PolygonScanner and friends.
Member
Author
There was a problem hiding this comment.
Awesome thanks! I didn't even know about the additional sort APIs. Removed.
Codecov Report
@@ Coverage Diff @@
## main #288 +/- ##
====================================
Coverage 80% 80%
====================================
Files 99 97 -2
Lines 5055 4875 -180
Branches 919 880 -39
====================================
- Hits 4050 3925 -125
+ Misses 807 753 -54
+ Partials 198 197 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dlemstra
previously approved these changes
Aug 16, 2023
JimBobSquarePants
requested review from
antonfirsov,
brianpopow,
dlemstra and
tocsoft
August 16, 2023 13:16
antonfirsov
approved these changes
Aug 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Removes all outdated
#if...#elseconditions from the code.