Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Tiff decoder: Fix issue 2679 - #2789

#2789
Merged
JimBobSquarePants merged 6 commits into
mainSixLabors/ImageSharp:mainfrom
bp/Issue2679SixLabors/ImageSharp:bp/Issue2679Copy head branch name to clipboard
Aug 6, 2024
Merged

Tiff decoder: Fix issue 2679#2789
JimBobSquarePants merged 6 commits into
mainSixLabors/ImageSharp:mainfrom
bp/Issue2679SixLabors/ImageSharp:bp/Issue2679Copy head branch name to clipboard

Conversation

@brianpopow

Copy link
Copy Markdown
Collaborator

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

This MR fixes issue #2679 with decoding TIFF images with Jpeg compression. This PR will set subsampling to 1:1 for jpeg compression, the jpeg decoder will handler subsampling, see discussion: #2679

Note that this will only be done for JpegCompression not OldJpegCompression. I am not sure, if we should do it for both.

@JimBobSquarePants JimBobSquarePants left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks!

@JimBobSquarePants
JimBobSquarePants merged commit 350e439 into main Aug 6, 2024
@JimBobSquarePants
JimBobSquarePants deleted the bp/Issue2679 branch August 6, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.