Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

TGA: Treat 32 bit True Color images always as transparent - #2643

#2643
Merged
brianpopow merged 5 commits into
mainSixLabors/ImageSharp:mainfrom
bp/Issue2629SixLabors/ImageSharp:bp/Issue2629Copy head branch name to clipboard
Jan 15, 2024
Merged

TGA: Treat 32 bit True Color images always as transparent#2643
brianpopow merged 5 commits into
mainSixLabors/ImageSharp:mainfrom
bp/Issue2629SixLabors/ImageSharp:bp/Issue2629Copy head branch name to clipboard

Conversation

@brianpopow

Copy link
Copy Markdown
Collaborator

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

This MR changes the tga decoder to always treat 32 bit true color images as images with transparency, because some encoders seems to not set the alpha bit flags in the image descriptor correctly.

This addresses issue #2629

@JimBobSquarePants JimBobSquarePants left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! 😍

@JimBobSquarePants JimBobSquarePants added this to the v4.0.0 milestone Jan 15, 2024
@brianpopow
brianpopow merged commit f926822 into main Jan 15, 2024
@brianpopow
brianpopow deleted the bp/Issue2629 branch January 15, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.