Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Explicitly set BitsPerPixel and BitsPerSample to 1 for bicolor compressed images - #2590

#2590
Merged
JimBobSquarePants merged 1 commit into
mainSixLabors/ImageSharp:mainfrom
bp/Issue2587SixLabors/ImageSharp:bp/Issue2587Copy head branch name to clipboard
Nov 25, 2023
Merged

Explicitly set BitsPerPixel and BitsPerSample to 1 for bicolor compressed images#2590
JimBobSquarePants merged 1 commit into
mainSixLabors/ImageSharp:mainfrom
bp/Issue2587SixLabors/ImageSharp:bp/Issue2587Copy head branch name to clipboard

Conversation

@brianpopow

@brianpopow brianpopow commented Nov 24, 2023

Copy link
Copy Markdown
Collaborator

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Explicitly set BitsPerPixel and BitsPerSample to 1 for bicolor compressed images, fixes #2587

@JimBobSquarePants JimBobSquarePants added this to the v3.1.0 milestone Nov 25, 2023
JimBobSquarePants
JimBobSquarePants approved these changes Nov 25, 2023
View reviewed changes

@JimBobSquarePants JimBobSquarePants left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks!

@JimBobSquarePants
JimBobSquarePants merged commit cc4c0b1 into main Nov 25, 2023
@JimBobSquarePants
JimBobSquarePants deleted the bp/Issue2587 branch November 25, 2023 05:48
@kandeepandev kandeepandev mentioned this pull request Nov 29, 2023
Closed
4 tasks
This was referenced Jul 30, 2025
Open
Open
Open
Open
This was referenced Sep 29, 2025
Closed
Closed
@dependabot dependabot Bot mentioned this pull request Oct 13, 2025
Closed
@dependabot dependabot Bot mentioned this pull request Nov 3, 2025
Closed
This was referenced Nov 17, 2025
Closed
Closed
@dependabot dependabot Bot mentioned this pull request Dec 18, 2025
Closed
@dependabot dependabot Bot mentioned this pull request Feb 3, 2026
Merged
@dependabot dependabot Bot mentioned this pull request Mar 1, 2026
Merged
@dependabot dependabot Bot mentioned this pull request Mar 14, 2026
Closed
This was referenced Mar 23, 2026
Closed
Open
@dependabot dependabot Bot mentioned this pull request Apr 18, 2026
Open
This was referenced Apr 26, 2026
Closed
Closed
This was referenced Jun 2, 2026
Closed
Open
@dependabot dependabot Bot mentioned this pull request Jun 19, 2026
Open
@dependabot dependabot Bot mentioned this pull request Jun 27, 2026
Open
@dependabot dependabot Bot mentioned this pull request Jul 21, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JimBobSquarePants JimBobSquarePants JimBobSquarePants approved these changes

Assignees

No one assigned

Labels

formats:tiff

Projects

None yet

Milestone

v3.1.0

Development

Successfully merging this pull request may close these issues.

The number of samples in the TIFF BitsPerSample entry is not supported.

2 participants

@brianpopow @JimBobSquarePants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.