Update to net8 - #2583
#2583Merged
Merged
Update to net8#2583
Conversation
stefannikolei
marked this pull request as ready for review
November 19, 2023 10:11
stefannikolei
commented
Nov 19, 2023
| <Include Path="..\shared-infrastructure\sixlabors.ruleset" Action="Default" /> | ||
| <Rules AnalyzerId="Microsoft.CodeAnalysis.CSharp.NetAnalyzers" RuleNamespace="Microsoft.CodeAnalysis.CSharp.NetAnalyzers"> | ||
| <Rule Id="CA1857" Action="None" /> | ||
| <Rule Id="CA1859" Action="None" /> |
Contributor
Author
There was a problem hiding this comment.
https://learn.microsoft.com/de-de/dotnet/fundamentals/code-analysis/quality-rules/ca1859
I disabled this to get a build without errors. I can remove it and fix all places
Member
There was a problem hiding this comment.
We should open up a discussion or issue to track it so it's not forgotten.
Member
There was a problem hiding this comment.
Just had a hack at this. Only 3 changes required in private methods.
Member
|
Thanks for this. You might want to put a pause on it though until we ship v3.1 We'll need to update SharedInfrastructure submodule following that. |
Contributor
Author
|
@JimBobSquarePants should we run the arm tests before we merge this? |
Member
|
@stefannikolei triggered. |
stefannikolei
commented
Dec 1, 2023
This was referenced Jul 5, 2026
This was referenced Jul 13, 2026
This was referenced Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description