Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Follow up on post-merge discussions in #2551 - #2552

#2552
Merged
JimBobSquarePants merged 1 commit into
mainSixLabors/ImageSharp:mainfrom
af/pbm-followupSixLabors/ImageSharp:af/pbm-followupCopy head branch name to clipboard
Oct 14, 2023
Merged

Follow up on post-merge discussions in #2551#2552
JimBobSquarePants merged 1 commit into
mainSixLabors/ImageSharp:mainfrom
af/pbm-followupSixLabors/ImageSharp:af/pbm-followupCopy head branch name to clipboard

Conversation

@antonfirsov

Copy link
Copy Markdown
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Minor tweaks for cleaner code.

@JimBobSquarePants JimBobSquarePants left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry about the confusion

@JimBobSquarePants
JimBobSquarePants merged commit d93bc6c into main Oct 14, 2023
@JimBobSquarePants
JimBobSquarePants deleted the af/pbm-followup branch October 14, 2023 19:51
JimBobSquarePants added a commit that referenced this pull request Oct 16, 2023
…eam observability (#2555)

* PBM decoder robustness improvements and BufferedReadStream observability

Backport of #2551 & #2552

* Remove DoesNotReturn attribute

---------

Co-authored-by: James Jackson-South <james_south@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.