Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Use System.Half for HalfTypeHelper - #2233

#2233
Merged
JimBobSquarePants merged 4 commits into
mainSixLabors/ImageSharp:mainfrom
js/system-halfSixLabors/ImageSharp:js/system-halfCopy head branch name to clipboard
Sep 16, 2022
Merged

Use System.Half for HalfTypeHelper#2233
JimBobSquarePants merged 4 commits into
mainSixLabors/ImageSharp:mainfrom
js/system-halfSixLabors/ImageSharp:js/system-halfCopy head branch name to clipboard

Conversation

@JimBobSquarePants

Copy link
Copy Markdown
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Replaces our incredibly complex custom packing code with System.Half plus casting.

Comment thread src/ImageSharp/PixelFormats/HalfTypeHelper.cs Outdated
Comment thread src/ImageSharp/PixelFormats/HalfTypeHelper.cs Outdated
JimBobSquarePants and others added 3 commits September 16, 2022 19:55
Co-authored-by: Theodore Tsirpanis <teo@tsirpanis.gr>
Co-authored-by: Theodore Tsirpanis <teo@tsirpanis.gr>

@brianpopow brianpopow left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better now 👍

@JimBobSquarePants
JimBobSquarePants merged commit 22a7cba into main Sep 16, 2022
@JimBobSquarePants
JimBobSquarePants deleted the js/system-half branch September 16, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.