Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Identify transparency for indexed PNG correctly - #2215

#2215
Merged
JimBobSquarePants merged 3 commits into
mainSixLabors/ImageSharp:mainfrom
bp/pngindexedtransSixLabors/ImageSharp:bp/pngindexedtransCopy head branch name to clipboard
Aug 29, 2022
Merged

Identify transparency for indexed PNG correctly#2215
JimBobSquarePants merged 3 commits into
mainSixLabors/ImageSharp:mainfrom
bp/pngindexedtransSixLabors/ImageSharp:bp/pngindexedtransCopy head branch name to clipboard

Conversation

@brianpopow

@brianpopow brianpopow commented Aug 24, 2022

Copy link
Copy Markdown
Collaborator

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

This PR fixes an issue that HasTransparency is not set for index PNG's.
This fixes #2209

@brianpopow
brianpopow requested a review from a team August 28, 2022 12:51
@JimBobSquarePants

JimBobSquarePants commented Aug 29, 2022

Copy link
Copy Markdown
Member

Thanks for this @brianpopow I tweaked it slightly to ensure that the assignment only happens when the alpha chunk has a length

@JimBobSquarePants
JimBobSquarePants merged commit 1b6728b into main Aug 29, 2022
@JimBobSquarePants
JimBobSquarePants deleted the bp/pngindexedtrans branch August 29, 2022 01:06
This was referenced Sep 29, 2025
Closed
Closed
@dependabot dependabot Bot mentioned this pull request Oct 13, 2025
Closed
@dependabot dependabot Bot mentioned this pull request Nov 3, 2025
Closed
This was referenced Nov 17, 2025
Closed
Closed
@dependabot dependabot Bot mentioned this pull request Dec 18, 2025
Closed
@dependabot dependabot Bot mentioned this pull request Feb 3, 2026
Merged
@dependabot dependabot Bot mentioned this pull request Mar 1, 2026
Merged
This was referenced Mar 23, 2026
Closed
Open
This was referenced Apr 26, 2026
Closed
Closed
This was referenced Jun 2, 2026
Closed
Open
@dependabot dependabot Bot mentioned this pull request Jun 27, 2026
Open
@dependabot dependabot Bot mentioned this pull request Jul 21, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JimBobSquarePants JimBobSquarePants JimBobSquarePants approved these changes

Assignees

No one assigned

Labels

area:metadata formats:png

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GetPngMetadata does not set HasTransparency correctly for palette-based PNGs

2 participants

@brianpopow @JimBobSquarePants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.