Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Deduce color space as YCbCr if component id's are 1, 2, 3 - #2135

#2135
Merged
brianpopow merged 2 commits into
mainSixLabors/ImageSharp:mainfrom
bp/Issue2133SixLabors/ImageSharp:bp/Issue2133Copy head branch name to clipboard
May 30, 2022
Merged

Deduce color space as YCbCr if component id's are 1, 2, 3#2135
brianpopow merged 2 commits into
mainSixLabors/ImageSharp:mainfrom
bp/Issue2133SixLabors/ImageSharp:bp/Issue2133Copy head branch name to clipboard

Conversation

@brianpopow

Copy link
Copy Markdown
Collaborator

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Another case of deducing the color space of a jpeg image based on the component id's.

Related issue #2133

@brianpopow
brianpopow requested a review from a team May 29, 2022 15:19

@br3aker br3aker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Image from the issue is neither jfif nor adobe jfif, it was encoded with app1 marker which we indeed ignored during color deduction. I didn't find any information regarding jpeg encoding color type from exif specs so component id color deduction seems to be a solution.

@brianpopow

Copy link
Copy Markdown
Collaborator Author

Looks good. Image from the issue is neither jfif nor adobe jfif, it was encoded with app1 marker which we indeed ignored during color deduction. I didn't find any information regarding jpeg encoding color type from exif specs so component id color deduction seems to be a solution.

@br3aker thanks for your feedback!

@antonfirsov antonfirsov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brianpopow
brianpopow merged commit 1b475ad into main May 30, 2022
@brianpopow
brianpopow deleted the bp/Issue2133 branch May 30, 2022 12:52
@JimBobSquarePants

Copy link
Copy Markdown
Member

Do you think we should backport this since we introduced the issue in the last patch?

@brianpopow

Copy link
Copy Markdown
Collaborator Author

Do you think we should backport this since we introduced the issue in the last patch?

I would not consider this a critical issue, it's more an edge case, so I don't think we need to backport this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.