Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Preserve color profile when encoding bitmaps - #2108

#2108
Merged
brianpopow merged 5 commits into
mainSixLabors/ImageSharp:mainfrom
bp/bmp-iccSixLabors/ImageSharp:bp/bmp-iccCopy head branch name to clipboard
May 7, 2022
Merged

Preserve color profile when encoding bitmaps#2108
brianpopow merged 5 commits into
mainSixLabors/ImageSharp:mainfrom
bp/bmp-iccSixLabors/ImageSharp:bp/bmp-iccCopy head branch name to clipboard

Conversation

@brianpopow

@brianpopow brianpopow commented May 7, 2022

Copy link
Copy Markdown
Collaborator

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

This PR changes the decoder to read the color profile when present and also the encoder to preserve it when encoding a bitmap.

Related to #2107

JimBobSquarePants
JimBobSquarePants approved these changes May 7, 2022
View reviewed changes

@JimBobSquarePants JimBobSquarePants left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was fast! 🚀 👍

@JimBobSquarePants JimBobSquarePants added this to the 3.0.0 milestone May 7, 2022
@brianpopow
brianpopow merged commit 2aa150c into main May 7, 2022
@brianpopow
brianpopow deleted the bp/bmp-icc branch May 7, 2022 14:17
@brianpopow brianpopow mentioned this pull request May 12, 2022
Closed
4 tasks
This was referenced Sep 29, 2025
Closed
Closed
@dependabot dependabot Bot mentioned this pull request Oct 13, 2025
Closed
@dependabot dependabot Bot mentioned this pull request Nov 3, 2025
Closed
This was referenced Nov 17, 2025
Closed
Closed
@dependabot dependabot Bot mentioned this pull request Dec 18, 2025
Closed
@dependabot dependabot Bot mentioned this pull request Feb 3, 2026
Merged
@dependabot dependabot Bot mentioned this pull request Mar 1, 2026
Merged
This was referenced Mar 23, 2026
Closed
Open
This was referenced Apr 26, 2026
Closed
Closed
This was referenced Jun 2, 2026
Closed
Open
@dependabot dependabot Bot mentioned this pull request Jun 27, 2026
Open
@dependabot dependabot Bot mentioned this pull request Jul 21, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JimBobSquarePants JimBobSquarePants JimBobSquarePants approved these changes

Assignees

No one assigned

Labels

formats:bmp metadata:icc

Projects

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@brianpopow @JimBobSquarePants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.