Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Code Quality Enhancements and Docs - #511

#511
Merged
JimBobSquarePants merged 3 commits into
mainSixLabors/Fonts:mainfrom
js/code-qualitySixLabors/Fonts:js/code-qualityCopy head branch name to clipboard
Mar 13, 2026
Merged

Code Quality Enhancements and Docs#511
JimBobSquarePants merged 3 commits into
mainSixLabors/Fonts:mainfrom
js/code-qualitySixLabors/Fonts:js/code-qualityCopy head branch name to clipboard

Conversation

@JimBobSquarePants

@JimBobSquarePants JimBobSquarePants commented Mar 13, 2026

Copy link
Copy Markdown
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

@codecov

codecov Bot commented Mar 13, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 47.91667% with 50 lines in your changes missing coverage. Please review.
✅ Project coverage is 82%. Comparing base (48b8ab1) to head (4798947).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/SixLabors.Fonts/Tables/General/Colr/Paint.cs 37% 48 Missing ⚠️
...abors.Fonts/Tables/General/CMap/Format4SubTable.cs 83% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@          Coverage Diff          @@
##            main    #511   +/-   ##
=====================================
  Coverage     82%     82%           
=====================================
  Files        305     305           
  Lines      21520   21528    +8     
  Branches    3161    3164    +3     
=====================================
+ Hits       17797   17806    +9     
+ Misses      2916    2911    -5     
- Partials     807     811    +4
Flag Coverage Δ
unittests 82% <47%> (+<1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JimBobSquarePants
JimBobSquarePants merged commit 0731ec5 into main Mar 13, 2026
46 checks passed
@JimBobSquarePants
JimBobSquarePants deleted the js/code-quality branch March 13, 2026 02:24
This was referenced May 12, 2026
Closed
Closed
Closed
Closed
Closed
Open
Closed
Open
This was referenced May 22, 2026
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api breaking bug codequality docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

IndexOutOfRangeException in Format4SubTable.TryGetGlyphId with malformed CMap table

1 participant

@JimBobSquarePants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.