Fix endSnippet block getting removed for missing snippet - #397
#397Fix endSnippet block getting removed for missing snippet#397SimonCropp merged 3 commits intoSimonCropp:masterSimonCropp/MarkdownSnippets:masterfrom mysticmind:fix_end_snippet_block_removalmysticmind/MarkdownSnippets:fix_end_snippet_block_removalCopy head branch name to clipboard
Conversation
- Fix endSnippet block getting removed for a missing snippet with config InPlaceOverwrite - Wrap the ** Count not find snippet in a fenced code block.
|
The problem is outlined below: When I run mdsnippets tool or via msbuild for a missing snippet, it strips off This PR fixes the same. I couldn't figure out a way to add unit tests for this case, please provide some clues, I will try to add the same. FYI, I am using MarkdownSnippets for Marten v4 docs which is currently being worked upon by me. |
|
can u add a test to verify this change |
I had added the above in my comment, still checking to see how to add a unit test. |
|
@SimonCropp I am closing this PR for now. I am able to reproduce the issue using the latest NuGet version 23.1.3. But not on the latest codebase on Git. |
|
I was able to reproduce this in the latest code in repo, I am committing the test shortly for your review. |
|
@SimonCropp the PR is ready for your review and next steps. Also it would be super helpful if you could release it to NuGet at the earliest once you confirm this PR is good. Thank you! |
|
thanks. deployed |
config InPlaceOverwrite
** Count not find snippet...in a fenced code block.