Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Tighten Windows ACL on session.json #19

Copy link
Copy link

Description

@ShortArrow
Issue body actions

Context

`src/IviCli.Infrastructure/Session/JsonSessionStore.cs:165`
notes that Windows ACL tightening is deferred — session.json
sits under the default user-profile path (`%LOCALAPPDATA%\ivi-cli\`)
and inherits the user's umbrella DACL.

On *nix, the file is mode 0600 (owner-only read/write). On
Windows, it inherits whatever the parent directory grants —
which on a typical lab/test workstation can be too permissive.

Scope

  • After write, apply an explicit DACL on Windows that grants
    full control only to the current user SID.
  • Use System.IO.FileSecurity or
    Microsoft.Win32.SafeHandles + SetKernelObjectSecurity.
  • Validate via icacls session.json in an integration test
    (nightly only — relies on Windows runner).

Acceptance

  • icacls %LOCALAPPDATA%\ivi-cli\session.json shows only
    <USER>:(F) (no BUILTIN\Users, no Authenticated Users).
  • Test added under tests/IviCli.Infrastructure.Tests/Session/
    with [Trait("OS","Windows")] filter.
Reactions are currently unavailable

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:securityTLS, ACL, PAT, auditTLS, ACL, PAT, auditenhancementNew feature or requestNew feature or requestpriority:lowNice to have, polish, future workNice to have, polish, future work

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    Morty Proxy This is a proxified and sanitized view of the page, visit original site.