Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

No-op - Pinning github actions to commit SHAs#793

Merged
byrichardpowell merged 1 commit into
mainShopify/shopify_python_api:mainfrom
kaiyi-pin-shasShopify/shopify_python_api:kaiyi-pin-shasCopy head branch name to clipboard
Apr 27, 2026
Merged

No-op - Pinning github actions to commit SHAs#793
byrichardpowell merged 1 commit into
mainShopify/shopify_python_api:mainfrom
kaiyi-pin-shasShopify/shopify_python_api:kaiyi-pin-shasCopy head branch name to clipboard

Conversation

@kyli

@kyli kyli commented Apr 27, 2026

Copy link
Copy Markdown
Contributor

Why?

By using some-org/some-action@v3 you are trusting a mutable tag. If the upstream repo is compromised, a force-pushed v3 ships malicious code into your workflow on the next run — see tj-actions/changed-files (March 2025) for recent real-world cases that leaked secrets across thousands of downstream workflows.

Pinning to a full 40-char SHA (uses: tj-actions/changed-files@<sha> # v45.0.3) makes the reference immutable and helps to mitigate this type of supply chain attacks.

cc @Shopify/dev_experience @byrichardpowell for review.

@kyli kyli requested a review from byrichardpowell April 27, 2026 19:07
@byrichardpowell byrichardpowell merged commit 307fa92 into main Apr 27, 2026
1 of 12 checks passed
@byrichardpowell byrichardpowell deleted the kaiyi-pin-shas branch April 27, 2026 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.