Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Extract CTE resolver from SelectReferenceResolver into dedicated internal class #218

Copy link
Copy link

Description

@DaveRMaltby
Issue body actions

Discovered by: /uber-report 2026-05-10 (SqlBuildingBlocks Architect)

Context

SelectReferenceResolver (706 lines) now handles eight responsibilities. The CTE pre-pass (ResolveCtes, RewriteCteReferences, WrapCteTable, ResolveNonRecursiveSetOperationTerms, ResolveRecursiveTerms) is ~200 lines substantially independent of the column-reference logic — they share only the read-only constructor parameters.

Both classes are internal, so this is not a NuGet surface concern.

Proposed Work

Extract CTE resolution to internal class CteReferenceResolver in src/Core/Utils/CteReferenceResolver.cs. SelectReferenceResolver.ResolveTablesDatabase calls new CteReferenceResolver(...).Resolve(sqlSelectDefinition, outerTablesInScope) at its head and receives back the populated outerTablesInScope (CTEs added) before proceeding to column resolution.

Acceptance Criteria

  • All 1279 existing tests pass without change
  • SelectReferenceResolver is under 550 lines
  • CteReferenceResolver is under 250 lines
  • Both classes remain internal
  • CTE resolution integration tests in AnsiSqlScenarioTests.cs pass
Reactions are currently unavailable

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    Morty Proxy This is a proxified and sanitized view of the page, visit original site.