Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

EF Core: Missing ISqlGenerationHelper with provider-specific identifier quoting #133

Copy link
Copy link

Description

@DaveRMaltby
Issue body actions

Summary

The EF Core providers register the generic RelationalSqlGenerationHelper rather than a provider-specific implementation. This means SQL generation uses default identifier quoting (double quotes) rather than the square bracket quoting ([identifier]) used by the ADO.NET layer's DbCommandBuilder.

Inconsistency

  • ADO.NET layer: Uses [ and ] for identifier quoting (set in FileCommandBuilder)
  • EF Core layer: Uses " for identifier quoting (default RelationalSqlGenerationHelper)

This mismatch could cause issues when EF Core generates SQL that the underlying ADO.NET command parser interprets differently.

What's Needed

A custom FileSqlGenerationHelper that:

  • Uses [ / ] for identifier quoting (matching the ADO.NET layer)
  • Sets the correct statement terminator
  • Handles provider-specific SQL syntax quirks

Location

Service registration: e.g., src/EFCore.Csv/Extensions/CsvServiceCollectionExtensions.cs
Currently: .AddSingleton<ISqlGenerationHelper, RelationalSqlGenerationHelper>()

Standard Reference

Reactions are currently unavailable

Metadata

Metadata

Assignees

No one assigned

    Labels

    deferredDeferred — not addressing nowDeferred — not addressing now

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    Morty Proxy This is a proxified and sanitized view of the page, visit original site.