Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Comments

Close side panel

Option to use CBVs and better priors #63

Merged
christinahedges merged 69 commits intoSSDataLab:masterSSDataLab/psfmachine:masterfrom
jorgemarpa:perturbation-cbvjorgemarpa/psfmachine:perturbation-cbvCopy head branch name to clipboard
Jul 1, 2022
Merged

Option to use CBVs and better priors #63
christinahedges merged 69 commits intoSSDataLab:masterSSDataLab/psfmachine:masterfrom
jorgemarpa:perturbation-cbvjorgemarpa/psfmachine:perturbation-cbvCopy head branch name to clipboard

Conversation

@jorgemarpa
Copy link
Contributor

@jorgemarpa jorgemarpa commented Jun 22, 2022

Two small changes/new features:

  • machine.build_time_model() accepts other_vectors as argument to add other type of model components from user-level, e.g. using CBVs as regressors.
  • Improved priors for in PerturbationMatrix. The prior follows ~ N(1, 0,5) which enforces "small" deviations from the mean model. This accounts for the mismatch in mean flux we saw before between PSF and PSF-NOVA and reduces the chances to get outlier data points.

TODO:

  • Fix test_perturbation_matrix3d()

Requires #60 to be merged first.

@jorgemarpa jorgemarpa added the enhancement New feature or request label Jun 22, 2022
@jorgemarpa jorgemarpa changed the title Option to use CBVs and better priors [WIP] Option to use CBVs and better priors Jun 22, 2022
@jorgemarpa jorgemarpa changed the title [WIP] Option to use CBVs and better priors Option to use CBVs and better priors Jun 28, 2022
@jorgemarpa
Copy link
Contributor Author

Using smooth CBVs instead of PCA components and adjusting the priors for the perturbation model improved the deviation from the mean_model as seen in the following figures:

x-axis: sum of the mean_model in the pixel dimension, i.e. the total PSF per source
y-axis: time-wise mean and standard deviation of the summed perturbed_model per source
histogram: ratio of above values

image

Data points of the 1-1 relation are sources with mismatching mean light curves before and after the time model and sources with spiky features (or added variability) after applying the time model.

image

After narrowing the priors the sources with bad time models are fixed.

@jorgemarpa jorgemarpa removed the request for review from christinahedges June 29, 2022 02:38
Copy link
Contributor

@christinahedges christinahedges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is 99.999%, I will merge when @jorgemarpa checks that the segments keyword is the desired behavior.

src/psfmachine/machine.py Show resolved Hide resolved
src/psfmachine/machine.py Show resolved Hide resolved
tests/test_perturbation.py Outdated Show resolved Hide resolved
@christinahedges christinahedges merged commit be52057 into SSDataLab:master Jul 1, 2022
@jorgemarpa jorgemarpa deleted the perturbation-cbv branch June 9, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.