Machine uses perturbation class#60
Machine uses perturbation class#60christinahedges merged 57 commits intoSSDataLab:masterSSDataLab/psfmachine:masterfrom jorgemarpa:machine-perturbationjorgemarpa/psfmachine:machine-perturbationCopy head branch name to clipboard
Conversation
Co-authored-by: Jorge Martínez-Palomera <jorgemarpa@users.noreply.github.com>
95d05bc to
5e2de68
Compare
Co-authored-by: Jorge Martínez-Palomera <jorgemarpa@users.noreply.github.com>
… into machine-perturbation
… into machine-perturbation
…o machine-perturbation
Co-authored-by: Christina Hedges <14965634+christinahedges@users.noreply.github.com>
jorgemarpa
left a comment
There was a problem hiding this comment.
@christinahedges I reviewed this PR again, added some minor docstrings, and removed duplicated functions in utils.py.
It looks Ok to me. Please review again before merging
christinahedges
left a comment
There was a problem hiding this comment.
I think this looks good, just two very minor docstring changes and then I will merge
src/psfmachine/perturbation.py
Outdated
| def pca(self, y, ncomponents=5, smooth_time_scale=0): | ||
| """Adds the principal components of `y` to the design matrix | ||
|
|
||
| Will add two time scales of principal components, definied by `long_time_scale` |
There was a problem hiding this comment.
This isn't true anymore can we fix this docstring here?
| pixels_in_tpf = np.ones_like(self.row, dtype=bool) | ||
|
|
||
| # enheance pixel mask | ||
| time_corr = np.nanpercentile(bkg_flux, 20, axis=1)[:, None] |
There was a problem hiding this comment.
Why is this 20%? Is this why stuff goes negative so often? Can you add a short docstring explainer about what's going on here?
There was a problem hiding this comment.
That part is only used to create a naive model of the background as a function of time to then find and mask out variable pixels. So it does not play into building the bkg model.
Changing the percentile will only change which pixels to look at in the distribution each time.
This PR adapts
machineto use the newperturbationclasses introduced in #59.It modifies the following methods:
self.build_time_model()self.plot_time_model()self.fit_models()self._get_perturbed_model(), computes the perturbed matrix for a given time.It adds a new attribute
self.P3which is aPerturbationMatrix3Dobject that manages the perturbation matrix.TODO:
EDIT:
The original
mac.time_corrector = "pos_corr", "centroid"options can be mimic by including the following arguments toPerturbationMatrix3Dat initialization:other_vectors = [poscorr1, poscorr2, poscorr1 * poscorr2], poly_order=0. In this way the perturbation matrix will use only the centroids/poscorr as components with no time.