Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

# Release 4.1.0#2

Merged
golluroSICKAG merged 8 commits into
SICKAppSpaceCodingStarterKit:mainSICKAppSpaceCodingStarterKit/CSK_Module_PersistentData:mainfrom
golluroSICKAG:mainCopy head branch name to clipboard
Nov 28, 2024
Merged

# Release 4.1.0#2
golluroSICKAG merged 8 commits into
SICKAppSpaceCodingStarterKit:mainSICKAppSpaceCodingStarterKit/CSK_Module_PersistentData:mainfrom
golluroSICKAG:mainCopy head branch name to clipboard

Conversation

@golluroSICKAG
Copy link
Copy Markdown
Contributor

@golluroSICKAG golluroSICKAG commented Aug 14, 2024

Version 4.1.0

New features

  • Provide version of module via 'OnNewStatusModuleVersion'
  • Function 'saveAllModuleConfigs' to trigger multiple / all running CSK modules to save their persistent data
  • Function to reload all apps ('reloadApps')
  • Function to reboot device ('rebootDevice')
  • Check if features of module can be used on device and provide this via 'OnNewStatusModuleIsActive' event / 'getStatusModuleActive' function
  • Function 'resetAllModules' and event 'OnResetAllModules' so that other modules can react by loading their default setup
  • Function 'removeData' to remove all data of current DataSet
  • Extra thread to trigger other modules to load their specific parameters if event 'OnNewDataToLoad' was notified

Improvements

  • New parameter for 'loadContent' to controle if other modules directly should react to new parameters
  • New UI design available (selectable via 'setUIStyle')
  • Added UI icon and browser tab information

Following tasks were checked

  • Module is coded and structured according to the "Developing guideline for modules" described within the CSK documentation
  • All functions/events/parameters are documented within the manifest documentation
  • The manifest description of the main CROWN includes main information about the purpose of the module and how to use it in general
  • API docu based on the manifest was created and stored within the "docu"-folder of the repository
  • Internal LUA code documentation exists for variables and non served functions
  • All relevant infos are logged via the SharedLogger 'ModuleLogger'
  • Module supports persistent data feature based on 'CSK_Module_PersistentData'
  • Module supports user management based on 'CSK_Module_UserManagement'
  • No open "ToDos" within the code or at least clearly explained comments why they exist...
  • "Version" key in app manifest was updated following semantic versioning (and use '0.x.y' for test / experimental modules which are not yet ready to be officially released)
  • Meaningful IDs used for UI elements
  • Module was tested on an AppSpace device (at least on SICK AppEngine) with no error message
  • README.md is up to date (incl. info of device + firmware the module was tested with)
  • CHANGELOG.md is up to date

@golluroSICKAG
# Release 4.1.0
a30dd95 
## New features
- Provide version of module via 'OnNewStatusModuleVersion'
- Function 'saveAllModuleConfigs' to trigger multiple / all running CSK modules to save their persistent data
- Function to reload all apps ('reloadApps')
- Function to reboot device ('rebootDevice')
- Check if features of module can be used on device and provide this via 'OnNewStatusModuleIsActive' event / 'getStatusModuleActive' function
- Function 'resetAllModules' and event 'OnResetAllModules' so that other modules can react by loading their default setup
- Function 'removeData' to remove all data of current DataSet
- Extra thread to trigger other modules to load their specific parameters if event 'OnNewDataToLoad' was notified

## Improvements
- New parameter for 'loadContent' to controle if other modules directly should react to new parameters
- New UI design available (selectable via 'setUIStyle')
- Added UI icon and browser tab information
@golluroSICKAG
- Minor docu in code
9b5892f
@golluroSICKAG
- Function to reboot device not supported by SAE and Emulator
054f65c
@golluroSICKAG
- Update of UI settings
601c511
kogliinSICKAG
kogliinSICKAG approved these changes Oct 2, 2024
View reviewed changes
Comment thread CSK_Module_PersistentData/scripts/Configuration/PersistentData/PersistentData_Controller.lua
Comment thread README.md
|SICK AppEngine|v1.7.0|v4.1.0|
|SICK AppEngine|v1.5.0|v4.0.1|
|InspectorP631|v4.2.1|v4.0.1|
|SIM1012|v2.4.2|v4.1.0|
Copy link
Copy Markdown
Contributor

@kogliinSICKAG kogliinSICKAG Oct 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SIM1012 latest firmware is v2.4.1

Comment thread CSK_Module_PersistentData/pages/pages/CSK_Module_PersistentData/CSK_Module_PersistentData.html
@golluroSICKAG
- Fixed issues of review
ce007da 
- Added function 'getCurrentParameterInfo' to get info what parameter file is currently in use
@golluroSICKAG
Copy link
Copy Markdown
Contributor Author

golluroSICKAG commented Oct 14, 2024

Thx for the review!

@golluroSICKAG golluroSICKAG merged commit e2d1222 into SICKAppSpaceCodingStarterKit:main Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kogliinSICKAG kogliinSICKAG kogliinSICKAG approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@golluroSICKAG @kogliinSICKAG
Morty Proxy This is a proxified and sanitized view of the page, visit original site.