Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Release 6.1.0#2

Merged
golluroSICKAG merged 16 commits into
SICKAppSpaceCodingStarterKit:mainSICKAppSpaceCodingStarterKit/CSK_Module_MultiRemoteCamera:mainfrom
golluroSICKAG:maingolluroSICKAG/CSK_Module_MultiRemoteCamera:mainCopy head branch name to clipboard
Feb 14, 2025
Merged

Release 6.1.0#2
golluroSICKAG merged 16 commits into
SICKAppSpaceCodingStarterKit:mainSICKAppSpaceCodingStarterKit/CSK_Module_MultiRemoteCamera:mainfrom
golluroSICKAG:maingolluroSICKAG/CSK_Module_MultiRemoteCamera:mainCopy head branch name to clipboard

Conversation

@golluroSICKAG
Copy link
Copy Markdown
Contributor

@golluroSICKAG golluroSICKAG commented Feb 5, 2025

Release 6.1.0

New features

  • Function to set image pool size
  • Check if persistent data to load provides all relevant parameters. Otherwise add default values.
  • React on "OnStopFlowConfigProviders" event of FlowConfig module to stop cameras

Improvements

  • Prevent to change camera type via UI if camera is already connected

Following tasks were checked

  • Module is coded and structured according to the "Developing guideline for modules" described within the CSK documentation
  • All functions/events/parameters are documented within the manifest documentation
  • The manifest description of the main CROWN includes main information about the purpose of the module and how to use it in general
  • API docu based on the manifest was created and stored within the "docu"-folder of the repository
  • Internal LUA code documentation exists for variables and non served functions
  • All relevant infos are logged via the SharedLogger 'ModuleLogger'
  • Module supports persistent data feature based on 'CSK_Module_PersistentData'
  • Module supports user management based on 'CSK_Module_UserManagement'
  • No open "ToDos" within the code or at least clearly explained comments why they exist...
  • "Version" key in app manifest was updated following semantic versioning (and use '0.x.y' for test / experimental modules which are not yet ready to be officially released)
  • Meaningful IDs used for UI elements
  • Module was tested on an AppSpace device (at least on SICK AppEngine) with no error message
  • README.md is up to date (incl. info of device + firmware the module was tested with)
  • CHANGELOG.md is up to date

@golluroSICKAG
# Release 6.0.0
b11a1a4 
## New features
- Supports FlowConfig feature to provide acquired images
- Set external event to trigger camera (see 'setSWTriggerEvent')
- Support for custom GigE Vision camera (see 'setCameraModel')
- Provide version of module via 'OnNewStatusModuleVersion'
- Function 'getParameters' to provide PersistentData parameters
- New function 'setSelectedInstance' to replace 'setSelectedCam'
- Check if features of module can be used on device and provide this via 'OnNewStatusModuleIsActive' event / 'getStatusModuleActive' function
- Function to 'resetModule' to default setup

## Improvements
- New UI design available (e.g. selectable via CSK_Module_PersistentData v4.1.0 or higher), see 'OnNewStatusCSKStyle'
- check if instance exists if selected
- 'loadParameters' returns its success
- 'sendParameters' can control if sent data should be saved directly by CSK_Module_PersistentData
- Changed log level of some messages from 'info' to 'fine'
- Added UI icon and browser tab information
@golluroSICKAG
- Update of UI settings
9e0ec2b
@golluroSICKAG
- Some minor edits
4e5c450
@golluroSICKAG
- Removed FlowConfig from UI
528317b
@golluroSICKAG
Try to ping IP of camera before trying to connect (prevents internal …
75948e0 
…error)
@golluroSICKAG
- Minor UI updates after review
4732e01
@golluroSICKAG
- Removing navigation bar entries
c2f0c33
@golluroSICKAG
Merge branch 'main' of https://github.com/golluroSICKAG/CSK_Module_Mu…
1ad4156 
…ltiRemoteCamera
@golluroSICKAG
## Release 6.1.0
f18a899 
### New features
- Function to set image pool size
- Check if persistent data to load provides all relevant parameters. Otherwise add default values.
- React on "OnStopFlowConfigProviders" event of FlowConfig module to stop cameras

### Improvements
- Prevent to change camera type via UI if camera is already connected
@golluroSICKAG
Minor API docu update
27fa82d
@golluroSICKAG
Updated FlowConfig behaviour
ad693e6
@golluroSICKAG
Minor API docu update
41d213b
@golluroSICKAG
Update of FlowConfig behaviour
c55c629
@golluroSICKAG
Update of CHANGELOG
d48cc42
@golluroSICKAG
Update of README
8d34fd7
@golluroSICKAG
* Minor fixes
41d7bf4
kogliinSICKAG
kogliinSICKAG approved these changes Feb 13, 2025
View reviewed changes
Copy link
Copy Markdown

@kogliinSICKAG kogliinSICKAG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not able to reproduce the issue of not stopping via FlowConfig. Thus, it looks good to me.

@golluroSICKAG golluroSICKAG merged commit f37a26a into SICKAppSpaceCodingStarterKit:main Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kogliinSICKAG kogliinSICKAG kogliinSICKAG approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@golluroSICKAG @kogliinSICKAG
Morty Proxy This is a proxified and sanitized view of the page, visit original site.