Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

# Release 5.0.0#2

Merged
golluroSICKAG merged 4 commits into
SICKAppSpaceCodingStarterKit:mainSICKAppSpaceCodingStarterKit/CSK_Module_MultiDeepLearning:mainfrom
golluroSICKAG:maingolluroSICKAG/CSK_Module_MultiDeepLearning:mainCopy head branch name to clipboard
Nov 28, 2024
Merged

# Release 5.0.0#2
golluroSICKAG merged 4 commits into
SICKAppSpaceCodingStarterKit:mainSICKAppSpaceCodingStarterKit/CSK_Module_MultiDeepLearning:mainfrom
golluroSICKAG:maingolluroSICKAG/CSK_Module_MultiDeepLearning:mainCopy head branch name to clipboard

Conversation

@golluroSICKAG
Copy link
Copy Markdown
Contributor

@golluroSICKAG golluroSICKAG commented Aug 14, 2024

Version 5.0.0

New features

  • Supports FlowConfig feature to set images to process / provide results
  • Provide version of module via 'OnNewStatusModuleVersion'
  • Function 'getParameters' to provide PersistentData parameters
  • Check if features of module can be used on device and provide this via 'OnNewStatusModuleIsActive' event / 'getStatusModuleActive' function
  • Function to 'resetModule' to default setup

Improvements

  • New UI design available (e.g. selectable via CSK_Module_PersistentData v4.1.0 or higher), see 'OnNewStatusCSKStyle'
  • check if instance exists if selected
  • check if models exist in selected folder
  • 'loadParameters' returns its success
  • 'sendParameters' can control if sent data should be saved directly by CSK_Module_PersistentData
  • Changed log level of some messages from 'info' to 'fine'
  • Sample images converted to JPG
  • Added UI icon and browser tab information

Bugfix

  • Never deregistered from events

Following tasks were checked

  • Module is coded and structured according to the "Developing guideline for modules" described within the CSK documentation
  • All functions/events/parameters are documented within the manifest documentation
  • The manifest description of the main CROWN includes main information about the purpose of the module and how to use it in general
  • API docu based on the manifest was created and stored within the "docu"-folder of the repository
  • Internal LUA code documentation exists for variables and non served functions
  • All relevant infos are logged via the SharedLogger 'ModuleLogger'
  • Module supports persistent data feature based on 'CSK_Module_PersistentData'
  • Module supports user management based on 'CSK_Module_UserManagement'
  • No open "ToDos" within the code or at least clearly explained comments why they exist...
  • "Version" key in app manifest was updated following semantic versioning (and use '0.x.y' for test / experimental modules which are not yet ready to be officially released)
  • Meaningful IDs used for UI elements
  • Module was tested on an AppSpace device (at least on SICK AppEngine) with no error message
  • README.md is up to date (incl. info of device + firmware the module was tested with)
  • CHANGELOG.md is up to date

@golluroSICKAG
# Release 5.0.0
e48181b 
## New features
- Supports FlowConfig feature to set images to process / provide results
- Provide version of module via 'OnNewStatusModuleVersion'
- Function 'getParameters' to provide PersistentData parameters
- Check if features of module can be used on device and provide this via 'OnNewStatusModuleIsActive' event / 'getStatusModuleActive' function
- Function to 'resetModule' to default setup

## Improvements
- New UI design available (e.g. selectable via CSK_Module_PersistentData v4.1.0 or higher), see 'OnNewStatusCSKStyle'
- check if instance exists if selected
- check if models exist in selected folder
- 'loadParameters' returns its success
- 'sendParameters' can control if sent data should be saved directly by CSK_Module_PersistentData
- Changed log level of some messages from 'info' to 'fine'
- Sample images converted to JPG
- Added UI icon and browser tab information

## Bugfix
- Never deregistered from events
@golluroSICKAG
- Update of UI settings
f17400a
tarnamaSICKAG
tarnamaSICKAG reviewed Oct 10, 2024
View reviewed changes
Comment thread CSK_Module_MultiDeepLearning/project.mf.xml Outdated
tarnamaSICKAG
tarnamaSICKAG approved these changes Oct 10, 2024
View reviewed changes
Copy link
Copy Markdown

@tarnamaSICKAG tarnamaSICKAG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

App Sieht auch gut aus :) Ein einziger Kommentar bezüglich Abkürzung ;)

@golluroSICKAG
- Fixed issues of review
e8b4232 
# Bugfix
- Error if module is not active but 'getInstancesAmount' was called
- processImageNUM did not work after deregistering from event to process images
@golluroSICKAG
Copy link
Copy Markdown
Contributor Author

golluroSICKAG commented Oct 14, 2024

Thx for the review!

@golluroSICKAG golluroSICKAG merged commit 254f8fc into SICKAppSpaceCodingStarterKit:main Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarnamaSICKAG tarnamaSICKAG tarnamaSICKAG approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@golluroSICKAG @tarnamaSICKAG
Morty Proxy This is a proxified and sanitized view of the page, visit original site.