Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Release 3.2.0#4

Merged
golluroSICKAG merged 13 commits into
SICKAppSpaceCodingStarterKit:mainSICKAppSpaceCodingStarterKit/CSK_Module_ImagePlayer:mainfrom
golluroSICKAG:maingolluroSICKAG/CSK_Module_ImagePlayer:mainCopy head branch name to clipboard
Jul 28, 2025
Merged

Release 3.2.0#4
golluroSICKAG merged 13 commits into
SICKAppSpaceCodingStarterKit:mainSICKAppSpaceCodingStarterKit/CSK_Module_ImagePlayer:mainfrom
golluroSICKAG:maingolluroSICKAG/CSK_Module_ImagePlayer:mainCopy head branch name to clipboard

Conversation

@golluroSICKAG
Copy link
Copy Markdown
Contributor

Release 3.2.0

New features

  • Check if persistent data to load provides all relevant parameters. Otherwise add default values

Bugfix

  • Legacy bindings of ValueDisplay elements within UI did not work if deployed with VS Code AppSpace SDK
  • UI differs if deployed via Appstudio or VS Code AppSpace SDK
  • Fullscreen icon of iFrame was visible

Following tasks were checked

  • Module is coded and structured according to the "Developing guideline for modules" described within the CSK documentation
  • All functions/events/parameters are documented within the manifest documentation
  • The manifest description of the main CROWN includes main information about the purpose of the module and how to use it in general
  • API docu based on the manifest was created and stored within the "docu"-folder of the repository
  • Internal LUA code documentation exists for variables and non served functions
  • All relevant infos are logged via the SharedLogger 'ModuleLogger'
  • Module supports persistent data feature based on 'CSK_Module_PersistentData'
  • Module supports user management based on 'CSK_Module_UserManagement'
  • No open "ToDos" within the code or at least clearly explained comments why they exist...
  • "Version" key in app manifest was updated following semantic versioning (and use '0.x.y' for test / experimental modules which are not yet ready to be officially released)
  • Meaningful IDs used for UI elements
  • Module was tested on an AppSpace device (at least on SICK AppEngine) with no error message
  • README.md is up to date (incl. info of device + firmware the module was tested with)
  • CHANGELOG.md is up to date

golluroSICKAG and others added 13 commits August 14, 2024 15:02
## New features
- Supports FlowConfig feature to forward loaded images
- Provide version of module via 'OnNewStatusModuleVersion'
- Function 'getParameters' to provide PersistentData parameters
- Check if features of module can be used on device and provide this via 'OnNewStatusModuleIsActive' event / 'getStatusModuleActive' function
- Function to 'resetModule' to default setup
- Provide new images in /resources

## Improvements
- Provide available folders auto suggestion in UI
- New UI design available (e.g. selectable via CSK_Module_PersistentData v4.1.0 or higher), see 'OnNewStatusCSKStyle'
- 'loadParameters' returns its success
- 'sendParameters' can control if sent data should be saved directly by CSK_Module_PersistentData
- Changed log level of some messages from 'info' to 'fine'
- Added UI icon and browser tab information
- Added FlowConfigPriority to stop player if new flow is activated
### Improvements
- Automatically start image provider after 3 seconds if used within FlowConfig
- React on "OnStopFlowConfigProviders" event of FlowConfig module to stop provider
- Optionally setup image path, type and cycle time within FlowConfig block
- Prevent changing of image type if player is currently active
## Bugfix
- Did not stop the image provider based on "OnStopFlowConfigProviders" event
## New features
- Check if persistent data to load provides all relevant parameters. Otherwise add default values

## Bugfix
- Legacy bindings of ValueDisplay elements within UI did not work if deployed with VS Code AppSpace SDK
- UI differs if deployed via Appstudio or VS Code AppSpace SDK
- Fullscreen icon of iFrame was visible
Copy link
Copy Markdown

@kogliinSICKAG kogliinSICKAG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This module seems to work fine as far as I have tested it.

Comment thread README.md
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this module (v3.2.0) on a SIM1012 with firmware v2.4.2.

Copy link
Copy Markdown

@kogliinSICKAG kogliinSICKAG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be working well as far as I have tested it.

@golluroSICKAG golluroSICKAG merged commit 32d74a0 into SICKAppSpaceCodingStarterKit:main Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.