Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Release 1.3.0#4

Merged
golluroSICKAG merged 14 commits into
SICKAppSpaceCodingStarterKit:mainSICKAppSpaceCodingStarterKit/CSK_Module_FlowConfig:mainfrom
golluroSICKAG:maingolluroSICKAG/CSK_Module_FlowConfig:mainCopy head branch name to clipboard
May 20, 2025
Merged

Release 1.3.0#4
golluroSICKAG merged 14 commits into
SICKAppSpaceCodingStarterKit:mainSICKAppSpaceCodingStarterKit/CSK_Module_FlowConfig:mainfrom
golluroSICKAG:maingolluroSICKAG/CSK_Module_FlowConfig:mainCopy head branch name to clipboard

Conversation

@golluroSICKAG

@golluroSICKAG golluroSICKAG commented Mar 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Release 1.3.0

New features

  • New logic 'RISING_EDGE' available within logic block

Improvement

  • Full UI usable via iFrame in other SensorApps
  • Include all internal blocks to show info that no extra UI exists

Bugfixes

  • Legacy bindings of ValueDisplay elements within UI did not work if deployed with VS Code AppSpace SDK
  • UI differs if deployed via Appstudio or VS Code AppSpace SDK
  • Fullscreen icon was visible within iFrame
  • Button for unsupported "Global parameters" was visible
  • Manifest check was not compatible with VS Code AppSpacek SDK
  • UI Bindings did not work with HTTPS

Following tasks were checked

  • Module is coded and structured according to the "Developing guideline for modules" described within the CSK documentation
  • All functions/events/parameters are documented within the manifest documentation
  • The manifest description of the main CROWN includes main information about the purpose of the module and how to use it in general
  • API docu based on the manifest was created and stored within the "docu"-folder of the repository
  • Internal LUA code documentation exists for variables and non served functions
  • All relevant infos are logged via the SharedLogger 'ModuleLogger'
  • Module supports persistent data feature based on 'CSK_Module_PersistentData'
  • Module supports user management based on 'CSK_Module_UserManagement'
  • No open "ToDos" within the code or at least clearly explained comments why they exist...
  • "Version" key in app manifest was updated following semantic versioning (and use '0.x.y' for test / experimental modules which are not yet ready to be officially released)
  • Meaningful IDs used for UI elements
  • Module was tested on an AppSpace device (at least on SICK AppEngine) with no error message
  • README.md is up to date (incl. info of device + firmware the module was tested with)
  • CHANGELOG.md is up to date

golluroSICKAG and others added 13 commits December 11, 2024 10:59
@golluroSICKAG
# Release 1.1.0
8631f84 
## Improvement
- New event "OnNewStatusFlowConfigReady" to state that module is ready after creating manifest for BlocksEditor (might be relevant for other modules)
@golluroSICKAG
## Release 1.2.0
aae7419 
### New features
- 'OnExpired' blocks to provide, periodically triggered via events. Multiple blocks can be used. (Replaces former 'OnNewValue' block)
- Logic blocks to solve simple logic operations directly within a flow
- New event 'OnStopFlowConfigProviders' to inform other modules to stop their FlowConfig related providers, e.g. via UI button (related modules need to be updated to support this feature)
@golluroSICKAG
- Stop internal timer for "OnNewValue" FlowConfig block
580a145
@golluroSICKAG
Minor docu edits
8768fc1
@golluroSICKAG
- Show message in UI if FlowConfig provider were stopped
cdf2296 
- Reset toggle status for OnExpired blocks
@golluroSICKAG
Merge branch 'main' into main
ddc72d6
@golluroSICKAG
Fix API docu
efe6b56
@golluroSICKAG
Merge branch 'SICKAppSpaceCodingStarterKit:main' into main
a9d7d34
@golluroSICKAG
# Release 1.2.1
bfe4f01 
## Improvement
- Full UI usable via iFrame in other SensorApps
- Hide fullscreen icon within iFrame
- Include all internal blocks to show info that no extra UI exists
@golluroSICKAG
- Hide non used button for "Global parameters"
c1b05e7
@golluroSICKAG
Adapt icon in docu
9a9efe7
@golluroSICKAG
# Release 1.3.0
07fdeec 
## New features
- New logic 'RISING_EDGE' available within logic block

## Improvements
- Full UI usable via iFrame in other SensorApps
- Include all internal blocks to show info that no extra UI exists

## Bugfixes
- Legacy bindings of ValueDisplay elements within UI did not work if deployed with VS Code AppSpace SDK
- UI differs if deployed via Appstudio or VS Code AppSpace SDK
- Fullscreen icon was visible within iFrame
- Button for unsupported "Global parameters" was visible
- Manifest check was not compatible with VS Code AppSpacek SDK
- UI Bindings did not work with HTTPS
@golluroSICKAG
Screenshot update
917c54b
@golluroSICKAG golluroSICKAG changed the title Release 1.2.1 Release 1.3.0 Apr 10, 2025
kogliinSICKAG
kogliinSICKAG reviewed May 9, 2025
View reviewed changes
Comment thread CSK_Module_FlowConfig/project.mf.xml
kogliinSICKAG
kogliinSICKAG approved these changes May 15, 2025
View reviewed changes

@kogliinSICKAG kogliinSICKAG left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the GUI with AppStudio, no obvious bugs found.
Some minor improvements committed via WebEx directly.

@golluroSICKAG golluroSICKAG merged commit 912b067 into SICKAppSpaceCodingStarterKit:main May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kogliinSICKAG kogliinSICKAG kogliinSICKAG approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@golluroSICKAG @kogliinSICKAG
Morty Proxy This is a proxified and sanitized view of the page, visit original site.