Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Release 2.2.2#5

Merged
golluroSICKAG merged 5 commits into
SICKAppSpaceCodingStarterKit:mainSICKAppSpaceCodingStarterKit/CSK_Module_DeviceNetworkConfig:mainfrom
golluroSICKAG:maingolluroSICKAG/CSK_Module_DeviceNetworkConfig:mainCopy head branch name to clipboard
Jul 28, 2025
Merged

Release 2.2.2#5
golluroSICKAG merged 5 commits into
SICKAppSpaceCodingStarterKit:mainSICKAppSpaceCodingStarterKit/CSK_Module_DeviceNetworkConfig:mainfrom
golluroSICKAG:maingolluroSICKAG/CSK_Module_DeviceNetworkConfig:mainCopy head branch name to clipboard

Conversation

@golluroSICKAG
Copy link
Copy Markdown
Contributor

@golluroSICKAG golluroSICKAG commented Jul 4, 2025

Release 2.2.2

Bugfix

  • Legacy bindings of ValueDisplay elements within UI did not work if deployed with VS Code AppSpace SDK
  • UI differs if deployed via Appstudio or VS Code AppSpace SDK
  • Fullscreen icon of iFrame was visible

Following tasks were checked

  • Module is coded and structured according to the "Developing guideline for modules" described within the CSK documentation
  • [ x] All functions/events/parameters are documented within the manifest documentation
  • The manifest description of the main CROWN includes main information about the purpose of the module and how to use it in general
  • API docu based on the manifest was created and stored within the "docu"-folder of the repository
  • Internal LUA code documentation exists for variables and non served functions
  • All relevant infos are logged via the SharedLogger 'ModuleLogger'
  • Module supports persistent data feature based on 'CSK_Module_PersistentData'
  • Module supports user management based on 'CSK_Module_UserManagement'
  • No open "ToDos" within the code or at least clearly explained comments why they exist...
  • "Version" key in app manifest was updated following semantic versioning (and use '0.x.y' for test / experimental modules which are not yet ready to be officially released)
  • Meaningful IDs used for UI elements
  • Module was tested on an AppSpace device (at least on SICK AppEngine) with no error message
  • README.md is up to date (incl. info of device + firmware the module was tested with)
  • CHANGELOG.md is up to date

golluroSICKAG and others added 3 commits December 5, 2024 10:59
@golluroSICKAG
# Release 2.2.1
1673b27 
## Bugfix
- Error with adding new DNS server (introduced in version 2.2.0)
@golluroSICKAG
Merge branch 'SICKAppSpaceCodingStarterKit:main' into main
3f6847c
@golluroSICKAG
# Release 2.2.2
8711f06 
## Bugfix
- Legacy bindings of ValueDisplay elements within UI did not work if deployed with VS Code AppSpace SDK
- UI differs if deployed via Appstudio or VS Code AppSpace SDK
- Fullscreen icon of iFrame was visible
@vasudarSICKAG
Copy link
Copy Markdown

vasudarSICKAG commented Jul 18, 2025

Review is done. Thanks!

kogliinSICKAG
kogliinSICKAG approved these changes Jul 18, 2025
View reviewed changes
Copy link
Copy Markdown

@kogliinSICKAG kogliinSICKAG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This module seems to be working well as far as I have tested it.

Comment thread README.md
|--|--|--|
|SIM800|V1.1.1|V2.2.2|
|SICK AppEngine|V1.7.0|V2.2.0|
|SIM1012|V2.4.2|V2.2.0|
Copy link
Copy Markdown

@kogliinSICKAG kogliinSICKAG Jul 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this module (v2.2.2) on a SIM1012 with firmware v2.4.2.

Comment thread README.md
Copy link
Copy Markdown

@kogliinSICKAG kogliinSICKAG Jul 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I also test this module (v2.2.2) on a SIM300 with firmware v1.0.1 to see whether the interface names are displayed correctly or whether it is disabled due to the control center?
Should I also test it with a SIM4000 or SIM2500 to see whether it can be used to set the IPs of the ethernet AND the field bus interfaces?

Copy link
Copy Markdown
Contributor Author

@golluroSICKAG golluroSICKAG Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessary, thx!

kogliinSICKAG
kogliinSICKAG approved these changes Jul 21, 2025
View reviewed changes
Copy link
Copy Markdown

@kogliinSICKAG kogliinSICKAG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the adaptations for SIM300 and SAE on a SIM1012 and a SIM300. It seems to be working.

@golluroSICKAG golluroSICKAG merged commit ca8f49a into SICKAppSpaceCodingStarterKit:main Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kogliinSICKAG kogliinSICKAG kogliinSICKAG approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@golluroSICKAG @vasudarSICKAG @kogliinSICKAG
Morty Proxy This is a proxified and sanitized view of the page, visit original site.