Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

DNS functionality added#1

Closed
verdeanSICKAG wants to merge 29 commits into
SICKAppSpaceCodingStarterKit:mainSICKAppSpaceCodingStarterKit/CSK_Module_DeviceNetworkConfig:mainfrom
verdeanSICKAG:mainverdeanSICKAG/CSK_Module_DeviceNetworkConfig:mainCopy head branch name to clipboard
Closed

DNS functionality added#1
verdeanSICKAG wants to merge 29 commits into
SICKAppSpaceCodingStarterKit:mainSICKAppSpaceCodingStarterKit/CSK_Module_DeviceNetworkConfig:mainfrom
verdeanSICKAG:mainverdeanSICKAG/CSK_Module_DeviceNetworkConfig:mainCopy head branch name to clipboard

Conversation

@verdeanSICKAG
Copy link
Copy Markdown
Contributor

@verdeanSICKAG verdeanSICKAG commented Aug 10, 2023

Version 2.1.0

New features

  • Added the possibility to configure nameservers via the UI

Following tasks were checked

  • Module is coded and structured according to the "Developing guideline for modules" described within the CSK documentation
  • All functions/events/parameters are documented within the manifest documentation
  • The manifest description of the main CROWN includes main information about the purpose of the module and how to use it in general
  • API docu based on the manifest was created and stored within the "docu"-folder of the repository
  • Internal LUA code documentation exists for variables and non served functions
  • All relevant infos are logged via the SharedLogger 'ModuleLogger'
  • Module supports persistent data feature based on 'CSK_Module_PersistentData'
  • Module supports user management based on 'CSK_Module_UserManagement'
  • No open "ToDos" within the code or at least clearly explained comments why they exist...
  • "Version" key in app manifest was updated following semantic versioning (and use '0.x.y' for test / experimental modules which are not yet ready to be officially released)
  • Meaningful IDs used for UI elements
  • Module was tested on an AppSpace device (at least on SICK AppEngine) with no error message
  • README.md is up to date (incl. info of device + firmware the module was tested with)
  • CHANGELOG.md is up to date

golluroSICKAG and others added 24 commits June 30, 2023 12:58
@golluroSICKAG
Initial commit
63833f6
@golluroSICKAG
# Version 4.0.0
4e09824 
## Repository moved to GitHub organization
@verdeanSICKAG
Added project script
1dd6d43
@verdeanSICKAG
Added first preview with the new DNS feature
d52628c
@verdeanSICKAG
Added data persistence module
e8b19d0
@verdeanSICKAG
edited
f9cf125
@verdeanSICKAG
edited
21da6a9
@verdeanSICKAG
Fixed dependencies
db2b9d7
@verdeanSICKAG
Fixed dependencies
f78c53f
@verdeanSICKAG
edited
f379629
@verdeanSICKAG
Resolved merge conflict
04e044a
@verdeanSICKAG
Fixed dependencies
81afff4
@verdeanSICKAG
Add 'dependencies/modulePersistentData/' from commit '4e0982476f466bb…
305d293 
…293c7508c71da43371dfc78ed'

git-subtree-dir: dependencies/modulePersistentData
git-subtree-mainline: 81afff4
git-subtree-split: 4e09824
@verdeanSICKAG
Added Homescreen
9857127 
Include data persistence module
@verdeanSICKAG
Increased version number
286c923 
Hided localhost as DNS
@verdeanSICKAG
Added icon in web UI
676dd59
@verdeanSICKAG
Updated crown api document
7ca30ae 
Updated screenshot
@verdeanSICKAG
updated
1eaae86
@verdeanSICKAG
Added changes V2.1.0
3bc6f3c
@verdeanSICKAG
Updated (V2.1.0)
c31e9e0
@verdeanSICKAG
Updated
7a13424
@verdeanSICKAG
Updated
1d1f64b
@verdeanSICKAG
updated
afb2791
@verdeanSICKAG
Updated
181cb48
@golluroSICKAG
Copy link
Copy Markdown
Contributor

golluroSICKAG commented Aug 15, 2023

Thx for your contribution!
We will have a look into it asap.
Cheers!

@golluroSICKAG
# PullRequest Review
879ea90 
## Improvements
- Renamed abbreviations in functions / events (dns -> DNS, Ip -> IP)
- Renamed "selectedDns" -> "selectDNSViaUI"
- Minor edits in UI to align items
- Minor code / docu edits
@golluroSICKAG
Copy link
Copy Markdown
Contributor

golluroSICKAG commented Aug 16, 2023

Hi!
I did a review of your fork and it looks really nice! Thx!

I just found some minor issues and created a pull request to your fork with recommended changes:
verdeanSICKAG#1

Please check my edits and eventually merge these changes into your fork before I will merge it into our repo. Thx!

@verdeanSICKAG
Copy link
Copy Markdown
Contributor Author

verdeanSICKAG commented Aug 16, 2023

Hi Roy,
I have adopted your changes. The module can be merged

@golluroSICKAG
Copy link
Copy Markdown
Contributor

golluroSICKAG commented Aug 17, 2023

Perfect!

As the repository within the CSK organization does not need the project specific files / folders, I removed them within another fork and merged it already here:
#2

I will close this PR now.

Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@verdeanSICKAG @golluroSICKAG
Morty Proxy This is a proxified and sanitized view of the page, visit original site.