Fix Win32 does not release capture on outside release of mouse button#3729
Open
Ryu204 wants to merge 1 commit into
SFML:masterSFML/SFML:masterfrom
Ryu204:bugfix/window-capture-releaseRyu204/SFML:bugfix/window-capture-releaseCopy head branch name to clipboard
Open
Fix Win32 does not release capture on outside release of mouse button#3729Ryu204 wants to merge 1 commit intoSFML:masterSFML/SFML:masterfrom Ryu204:bugfix/window-capture-releaseRyu204/SFML:bugfix/window-capture-releaseCopy head branch name to clipboard
Ryu204 wants to merge 1 commit into
SFML:masterSFML/SFML:masterfrom
Ryu204:bugfix/window-capture-releaseRyu204/SFML:bugfix/window-capture-releaseCopy head branch name to clipboard
Conversation
Member
|
ClangCL, MinGW and macOS failures are expected currently, should eventually be fixed with #3728 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is related to the issue #3724. Previously, a Win32 window would not release the mouse capture if its buttons were released after the mouse had stopped moving and stayed still outside.
The PR checks inside the window event handler for available capture release in case the received message is mouse button up.
Tasks
How to test this PR?
Please see #3724 (comment) to reproduce this bug.