changeTest#1840
Closed
wangxuewen wants to merge 76 commits into
Closed
Conversation
Option is SDWebImageScaleDownLargeImage
Option is SDWebImageScaleDownLargeImage
Conflicts: SDWebImage/SDWebImageDecoder.m
Code copy from the Apple Sample code "Large Image Downsizing" https://developer.apple.com/Library/ios/samplecode/LargeImageDownsizing/Introduction/Intro.html#//apple_ref/doc/uid/DTS40011173-Intro-DontLinkElementID_2
Because of missing SD_UIKIT definition.
Fix FLAnimatedImageView+WebCache.m not got compiled
Add an option to scale down large images on iOS
…t the other decoder tests
…ted initializer.
…onent. Now we need to add examples for the most common cases.
Word corrections
Fix FLAnimatedImage import when using CocoaPods
add a network error situation
Update the method name in the README to match the method name in 4.0.0.
Small README Update For 4.0.0
- Fixed SDImageCacheConfig class name in Changelog.md
… CFBundleVersion if set as in Info.plist files. In WebImage/Info.plist is set explicitly to 400.
Correct available subspecs in README
For those who using cocoapods and gifs.
CFBundleVersion fix for 4.0.0 release
…tVersionString - same as for AFNetworking)
…-access-bug #1801: Makes sure UIActivityIndicator view is always initialized on main thread
… for self.activityIndicator on one thread and allocating on another. Also, made sure `sd_removeActivityIndicator` executes on the main queue
…aration-fix SDImageCacheConfig forward declaration changed to import
Making image downloading cache policy more clearer
Contributor
|
@wangxuewen can you please provide some more info regarding this huge pull? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
I have read and understood the CONTRIBUTING guide
I have read the Documentation
I have searched for a similar pull request in the project and found none
I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)
I have added the required tests to prove the fix/feature I am adding
I have updated the documentation (if necessary)
I have run the tests and they pass
I have run the lint and it passes (
pod lib lint)This merge request fixes / reffers to the following issues: ...
Pull Request Description
...