Fix deprecation messages for default values#329
Merged
Merged
Fix deprecation messages for default values#329
Conversation
The extension should only recommend usage of non-deprecated config parameters. There is a small number of deprecated parameters that have their own deprecated fall-backs. But since they had no default value, the check to print the deprecation message was positive even when the property was not set explicitly. Adding the default values removes the deprecation message. This is correct when it is not explicitly given. Signed-off-by: Karsten Schnitter <k.schnitter@sap.com>
Formatting has been changed. Only real change is the name of the dynatrace token-name property. Signed-off-by: Karsten Schnitter <k.schnitter@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The extension should only recommend usage of non-deprecated config parameters.
There is a small number of deprecated parameters that have their own deprecated
fall-backs. But since they had no default value, the check to print the deprecation
message was positive even when the property was not set explicitly. Adding the
default values removes the deprecation message. This is correct when it is not
explicitly given.