Fix instancecheck, subclasscheck of UnionType#3984
Merged
Merged
Fix instancecheck, subclasscheck of UnionType#3984
instancecheck, subclasscheck of UnionType#3984Conversation
instancecheck, subclasscheck of UnionTypeinstancecheck, subclasscheck of UnionType
Member
|
@Snowapril could you review this PR? |
Snowapril
reviewed
Jul 30, 2022
Contributor
Author
|
I made |
Snowapril
approved these changes
Jul 31, 2022
Member
|
The changes looks great, thank you! Just one more request. Could you rebase this PR to 2 commits - one for test changes and the other one for non-test code changes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve
test_types::UnionTests::test_instancecheck, test_bad_instancecheck,test_bad_subclasscheck