fix(semgrep): capture end.line so multi-line findings use the full annotation range#80
Open
Valyrian-Code wants to merge 1 commit into
RocketChat:developRocketChat/layne:developfrom
Valyrian-Code:fix/semgrep-end-lineValyrian-Code/layne:fix/semgrep-end-lineCopy head branch name to clipboard
Open
fix(semgrep): capture end.line so multi-line findings use the full annotation range#80Valyrian-Code wants to merge 1 commit intoRocketChat:developRocketChat/layne:developfrom Valyrian-Code:fix/semgrep-end-lineValyrian-Code/layne:fix/semgrep-end-lineCopy head branch name to clipboard
Valyrian-Code wants to merge 1 commit into
RocketChat:developRocketChat/layne:developfrom
Valyrian-Code:fix/semgrep-end-lineValyrian-Code/layne:fix/semgrep-end-lineCopy head branch name to clipboard
Conversation
…nnotation range
Semgrep emits both start.line and end.line in its JSON output but the
adapter only read start.line and left startLine/endLine unset. Every
Semgrep annotation therefore collapsed to a single line even for rules
that match multi-line constructs. Added end?: {line} to SemgrepRawResult
and populate startLine/endLine in toFinding, falling back to startLine
when end is absent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
start.lineandend.line, butSemgrepRawResultonly declaredstartandtoFindingnever populatedstartLine/endLine.SemgrepFindingtype already hadstartLine?: numberandendLine?: number— the implementation just never filled them.Fix
Added
end?: { line: number }toSemgrepRawResultand populatestartLine/endLineintoFinding. Falls back tostartLinewhenendis absent.Test plan
startLine === endLine === start.linestartLinefromstart.lineandendLinefromend.lineendfield falls backendLinetostartLinenpm test— 635 tests, 0 failures