Fixed property from interface implemented by trait - #1487
#1487Merged
Ocramius merged 1 commit intoFeb 12, 2025
Roave:6.57.xRoave/BetterReflection:6.57.xfrom
ondrejmirtes:trait-interface-propertyondrejmirtes/BetterReflection:trait-interface-propertyCopy head branch name to clipboard
Merged
Fixed property from interface implemented by trait#1487Ocramius merged 1 commit intoRoave:6.57.xRoave/BetterReflection:6.57.xfrom ondrejmirtes:trait-interface-propertyondrejmirtes/BetterReflection:trait-interface-propertyCopy head branch name to clipboard
Ocramius merged 1 commit into
Roave:6.57.xRoave/BetterReflection:6.57.xfrom
ondrejmirtes:trait-interface-propertyondrejmirtes/BetterReflection:trait-interface-propertyCopy head branch name to clipboard
Conversation
Contributor
Author
|
Days without bugs in property hooks: 0 |
Contributor
Author
|
The problem here is that BR looks for the property in interface first and completely skips the implementation in the used trait. |
kukulich
force-pushed
the
trait-interface-property
branch
from
February 12, 2025 20:07
45952b9 to
94b7e42
Compare
kukulich
force-pushed
the
trait-interface-property
branch
from
February 12, 2025 20:08
94b7e42 to
fedbd2a
Compare
kukulich
marked this pull request as ready for review
February 12, 2025 20:09
kukulich
force-pushed
the
trait-interface-property
branch
from
February 12, 2025 20:16
fedbd2a to
8f5e710
Compare
Ocramius
approved these changes
Feb 12, 2025
Ocramius
left a comment
Member
There was a problem hiding this comment.
Noice!
I mean, it's still a monstrosity, but the fix is nice.
Member
|
Thanks @kukulich! |
Contributor
Author
|
Thank you very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.