feat!: migrate build to pure ESM and TypeScript#310
Merged
Merged
feat!: migrate build to pure ESM and TypeScript#310
Conversation
sxzz
marked this pull request as ready for review
July 16, 2026 06:16
43081j
reviewed
Jul 16, 2026
| @@ -0,0 +1,11 @@ | ||
| import { defineConfig } from 'tsdown' | ||
|
|
||
| export default defineConfig({ |
Contributor
There was a problem hiding this comment.
Now that we don't need a bundle, can you explain tsdown's use here?
Contributor
Author
There was a problem hiding this comment.
- Remove the
DEBUGvariable - Before this PR, magic-string is shipping single file for each format, instead of multiple files.
Contributor
|
A big chunk of this seems to be formatting changes. It would be better to leave the formatting as is (prettier defaults) I think. Then suggest that in its own change if still wanted. Otherwise lots of good here 🎉 Will finish reading through it today |
Contributor
Author
|
@43081j Now the first commit is TS refactoring and the second one is formatting only. |
antfu
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #309, closes #301