Patches#30
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #26. This is a complete rethink of how magic-string works – rather than progressively overwriting a string with new content, and keeping track of mappings between the original and the result, this version accumulates edits non-destructively.
This allows us to loosen some of the restrictions on where edits (and slices) can be made, and paves the way for new functionality such as that sought in #26 and (possibly) #14. It may also be more performant.
Breaking changes:
magicString.locate(...)andmagicString.locateOrigin(...)are deprecated. These methods were used internally but are now no longer needed – if an external consumer of the library is using those methods it's probably for a bad reason (such as magic-string not having other methods that are necessary). Having said that, if it turns out they do have valid uses, we could reimplement them.