Draft
Conversation
Andy--S
requested review from
Copilot and
mondain
and removed request for
mondain
June 5, 2025 13:18
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces changes to support concurrency experiments by refactoring the handling of the IoBuffer data field and adding a new mechanism for performing forked event duplication.
- Updated version number in pom.xml
- Removed duplicate IoBuffer fields from several event classes, moving the data field to BaseEvent
- Added forkedDuplicate implementations in VideoData, Notify, and AudioData and new concurrency logic in BaseEvent
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pom.xml | Bumped server version from 2.0.18 to 2.0.19 |
| common/src/main/java/org/red5/server/net/rtmp/event/VideoData.java | Removed duplicate IoBuffer field and added forkedDuplicate method |
| common/src/main/java/org/red5/server/net/rtmp/event/Unknown.java | Removed duplicate IoBuffer field |
| common/src/main/java/org/red5/server/net/rtmp/event/Notify.java | Removed duplicate IoBuffer field and added forkedDuplicate method |
| common/src/main/java/org/red5/server/net/rtmp/event/BaseEvent.java | Moved IoBuffer field to BaseEvent and added concurrency support methods |
| common/src/main/java/org/red5/server/net/rtmp/event/AudioData.java | Removed duplicate IoBuffer field and added forkedDuplicate method |
| common/src/main/java/org/red5/server/net/rtmp/event/Aggregate.java | Removed duplicate IoBuffer field |
Comments suppressed due to low confidence (1)
common/src/main/java/org/red5/server/net/rtmp/event/BaseEvent.java:130
- Consider marking forkedDuplicate() as abstract in BaseEvent rather than providing a default implementation that returns null, to ensure that all subclasses implement this method appropriately.
public BaseEvent forkedDuplicate() {
|
|
||
| public BaseEvent forkedDuplicate() { | ||
| return null; | ||
| }; |
There was a problem hiding this comment.
The semicolon after the closing brace of the forkedDuplicate() method is unnecessary in Java; consider removing it to adhere to standard style conventions.
Suggested change
| }; | |
| } |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.