fix(cli): skip thought parts in copy output#4738
Merged
tanzhenxin merged 1 commit intoJun 4, 2026
QwenLM:mainQwenLM/qwen-code:mainfrom
he-yufeng:fix/copy-visible-outputhe-yufeng/qwen-code:fix/copy-visible-outputCopy head branch name to clipboard
Merged
fix(cli): skip thought parts in copy output#4738tanzhenxin merged 1 commit intoQwenLM:mainQwenLM/qwen-code:mainfrom he-yufeng:fix/copy-visible-outputhe-yufeng/qwen-code:fix/copy-visible-outputCopy head branch name to clipboard
tanzhenxin merged 1 commit into
QwenLM:mainQwenLM/qwen-code:mainfrom
he-yufeng:fix/copy-visible-outputhe-yufeng/qwen-code:fix/copy-visible-outputCopy head branch name to clipboard
Conversation
wenshao
approved these changes
Jun 3, 2026
wenshao
left a comment
Collaborator
There was a problem hiding this comment.
No issues found. LGTM! ✅ — qwen3.7-max via Qwen Code /review
Collaborator
PR #4738 Local Verification ReportBranch: Changes Summary
Test Results
Pre-existing TypeCheck Errors (not from this PR)
Verdict✅ Ready to merge. Clean single-commit change. All unit tests pass, lint clean, no new type errors introduced. The thought-part filtering logic is straightforward and well-tested. Verified by wenshao |
tanzhenxin
approved these changes
Jun 4, 2026
tanzhenxin
left a comment
Collaborator
There was a problem hiding this comment.
Approving. Small, well-tested change: /copy now filters out thought parts. CI green across macOS/Ubuntu/Windows (Node 22), lint and CodeQL pass, no new type errors. Confirmed by local review and wenshao's verification report.
xaelistic
pushed a commit
to xaelistic/qwen-code
that referenced
this pull request
Jun 7, 2026
Co-authored-by: Jacob Richman <jacob314@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4733.
/copycurrently builds the clipboard text from every text part in the last model message. Reasoning providers can keep internal reasoning as text parts marked withthought: true, so the command can copy hidden/internal thinking together with the visible answer.This changes
/copyto copy only visible text parts and leaves thought parts out of the clipboard output. Code/LaTeX selectors still run against the same visible output text.Validation
npm run test --workspace=@qwen-code/qwen-code -- src/ui/commands/copyCommand.test.tsnpx eslint packages/cli/src/ui/commands/copyCommand.ts packages/cli/src/ui/commands/copyCommand.test.tsnpx prettier --check packages/cli/src/ui/commands/copyCommand.ts packages/cli/src/ui/commands/copyCommand.test.tsgit diff --checkExisting baseline failures observed
npm run typecheck --workspace=@qwen-code/qwen-codecurrently fails on unrelated workspace/core export and Ink type errors, including missingformatDenialStateLog,atomicWriteFileSync,ink/dom, andFinishReason.IMAGE_*symbols.npm run build --workspace=@qwen-code/qwen-code-corecurrently fails on unrelatedFinishReason.IMAGE_RECITATION/FinishReason.IMAGE_OTHERreferences.