801 event edit can also be moved to settings event#1180
Open
fvacek wants to merge 32 commits into
mainQuick-Box/quickevent:mainfrom
801-event-edit-can-also-be-moved-to-settings---eventQuick-Box/quickevent:801-event-edit-can-also-be-moved-to-settings---eventCopy head branch name to clipboard
Open
801 event edit can also be moved to settings event#1180fvacek wants to merge 32 commits intomainQuick-Box/quickevent:mainfrom 801-event-edit-can-also-be-moved-to-settings---eventQuick-Box/quickevent:801-event-edit-can-also-be-moved-to-settings---eventCopy head branch name to clipboard
fvacek wants to merge 32 commits into
mainQuick-Box/quickevent:mainfrom
801-event-edit-can-also-be-moved-to-settings---eventQuick-Box/quickevent:801-event-edit-can-also-be-moved-to-settings---eventCopy head branch name to clipboard
Conversation
- Replace StageData from QVariantMap with a struct of typed fields startDateTime, useAllMaps, drawingConfig, qxApiToken - Update code to access fields directly - Load defaults from legacy stages table and apply config precedence - Remove the stage.cpp file and simplify stage.h accordingly - Migrate API token flow across qx client components - Normalize startDateTime with system timezone on load/save
- Rename m_btStage to m_btCurrentStage in AppStatusBar - Update all references to the new field - Set lime background on the current stage button - Update setStageNo to use the new button - Remove UseListViewForComboBoxItems option from EventPlugin dialog
- Use defaulted EventConfig constructor and remove empty ctor - Iterate dirty_vals with asKeyValueRange to access keys safely - Disable a verbose DB event log line in OFeedClient - Capture http_status and response_text in callback_error lambda - Comment out competitor_id retrieval and JSON change logging in OFeed
Collaborator
Author
Move stage data getters/setters into EventConfig and persist changes via
AppDbConfig (setEventConfig + save("event")). Update callers to use
appDbConfig()->eventConfig().stageData(...) / setStageData(...). Remove
EventPlugin's stage cache and its legacy
stageData/setStageData/clearStageDataCache
implementations and adjust related code. Add EventConfig::stageData and
setStageData methods.
Disable Qx client/service and remove qxApiToken from StageConfig. Populate missing STAGE entries from the database. Fix typo in helper name and add static_cast for a bounds check.
Refactor EventPlugin API and update call sites to use the eventDbName property and signals. Simplify AppDbConfig path handling: pass keys and integer stage_id instead of QStringList and parse key sections. Add linkUrl to ReceiptsConfig serialization. Miscellaneous cleanups: remove unused functions, fix nullptr constructor arg, update QML property calls, and qualify getPlugin usage.
Add changedValues helper to compute diffs between QVariantMaps. Use it in setters to save only modified entries and skip saving when data is empty. Add setQxConfig to support Qx config updates.
Collaborator
|
Good job, it simplifies the UI a lot. Just two small issues i noticed while testing:
|
Collaborator
Author
I was thinking about this, but I still feel, that current stage is important information and should be highly visible. I prefer this location |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#801
AppDbConfig.EventConfigusage with typed config structs.stagestable rows for FK compatibility.EventPluginevent identifier usage toeventDbName.eventConfigaccess.