Warning propagation improvements #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm. |
|
Sure, should I add it to |
|
I've added a test - let me know if it's in the wrong place or not quite right in some other way. ( |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear MySQLdb team,
Here are a couple of suggestions regarding warnings issued by the library:
I thought it would make sense for the
Warninginstances to not just have a string argument but, same as with errors, to also include the error code (as first argument, with string being second).db.warning_count()was called duringnextset(). However, for unbuffered queries, the warning count is not available until the whole result has been fetched. By instead callingdb.warning_count()later via_warning_checkinstead (which work as_defer_warningsis set), warnings are always received.