Warning propagation improvements #491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies for failures - I shall investigate |
- Include error code in warnings, not just string - Fix warning propagation for unbuffered queries
|
The problem was due to a warning not being propagated with an unbuffered cursor until the next query has been started (both DML, see change in I also added a unit test - hope that's the right place for it. Also, is the "coverage decreased" warning a red herring or have I done something wrong? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear PyMySQL team,
Here are a couple of suggestions (similar to what I submitted to MySQLdb#101 regarding warning handling in your library:
I thought it would make sense for the
Warninginstances to not just have a string argument but, same as with errors, to also include the error code (as first argument, with string being second).Since warning count is not available until whole result has been fetched, handle warnings "deferred" (simiarly to MySQldb)