Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Changed initial value of for loop indexer to 0 (from 1)#86

Merged
daviwil merged 1 commit into
PowerShell:masterPowerShell/vscode-powershell:masterfrom
rkeithhill:rkeithhill/for-snippet-bad-initvaluerkeithhill/vscode-powershell:rkeithhill/for-snippet-bad-initvalueCopy head branch name to clipboard
Feb 6, 2016
Merged

Changed initial value of for loop indexer to 0 (from 1)#86
daviwil merged 1 commit into
PowerShell:masterPowerShell/vscode-powershell:masterfrom
rkeithhill:rkeithhill/for-snippet-bad-initvaluerkeithhill/vscode-powershell:rkeithhill/for-snippet-bad-initvalueCopy head branch name to clipboard

Conversation

@rkeithhill

Copy link
Copy Markdown
Contributor

No description provided.

@daviwil

daviwil commented Feb 6, 2016

Copy link
Copy Markdown
Contributor

Nice catch!

daviwil added a commit that referenced this pull request Feb 6, 2016
…tvalue

Changed initial value of for loop indexer to 0 (from 1)
@daviwil daviwil merged commit 2ce53fc into PowerShell:master Feb 6, 2016
@rkeithhill rkeithhill deleted the rkeithhill/for-snippet-bad-initvalue branch February 6, 2016 20:04
andyleejordan added a commit that referenced this pull request May 15, 2026
Routine dependency refresh. Bumped patch/minor versions across the board
and a few majors:

- `uuid` 13 → 14 (only used as `v4` in `ExternalApi.ts`, no API changes)
- `sinon` 21 → 22 (`@types/sinon` not yet published for 22, staying on 21)
- `@types/vscode` ~1.110.0 → ~1.115.0 to align with `engines.vscode`
  ^1.114.0 (1.114 isn't published; 1.115 is the closest matching patch
  series). I held off bumping `engines.vscode` itself this round.
- Various minor/patch bumps: `@vscode/extension-telemetry`, `semver`,
  `@vscode/vsce`, `@types/node`, `@ungap/structured-clone`, `eslint`,
  `prettier`, `typescript`, `typescript-eslint`.

Skipped `@types/node` 25 (we're pinned to 22 to match Electron 39 / Node
22 in VS Code 1.114) and `untildify` 6 (ESM-only, we're CJS).

The `serialize-javascript` and `diff` overrides are still required —
mocha pulls in vulnerable transitive versions otherwise. I verified
both: removing either re-introduces the advisories. `npm audit` is
clean.

Resolves the two open Dependabot alerts:
- #86: `uuid` missing buffer bounds check in `v3`/`v5`/`v6` (fixed by
  the bump to `uuid` 14, which also pulls a patched 13.x transitively).
- #87: `fast-uri` path traversal / host confusion (now on 3.1.2 via
  `@vscode/vsce` 3.9.1 → `@secretlint/node` → `ajv`).

Verified `npm run compile`, `npm run lint`, `npm run format`, and
`npm audit` all pass.

Drafted by Copilot (Claude Opus 4.7).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.