Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix pre-existing TypeScript and ESLint errors#5449

Closed
Copilot wants to merge 2 commits into
mainPowerShell/vscode-powershell:mainfrom
copilot/attempt-safe-npm-package-upgradesPowerShell/vscode-powershell:copilot/attempt-safe-npm-package-upgradesCopy head branch name to clipboard
Closed

Fix pre-existing TypeScript and ESLint errors#5449
Copilot wants to merge 2 commits into
mainPowerShell/vscode-powershell:mainfrom
copilot/attempt-safe-npm-package-upgradesPowerShell/vscode-powershell:copilot/attempt-safe-npm-package-upgradesCopy head branch name to clipboard

Conversation

Copilot AI commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

Two static analysis errors that cause tsc --noEmit and eslint to fail with a clean checkout.

  • src/session.ts: TelemetryReporter is a named export, not a default export. Changed to named import to match the pattern already used in src/extension.ts:
    // before
    import TelemetryReporter, { ... } from "@vscode/extension-telemetry";
    // after
    import { TelemetryReporter, ... } from "@vscode/extension-telemetry";
  • src/settings.ts: Removed redundant type argument on configuration.get<TSetting>(key, value) — the type is inferred from value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.