Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Use official OneBranch template by default for CodeQL#5289

Merged
andyleejordan merged 1 commit into
mainPowerShell/vscode-powershell:mainfrom
onebranchPowerShell/vscode-powershell:onebranchCopy head branch name to clipboard
Oct 7, 2025
Merged

Use official OneBranch template by default for CodeQL#5289
andyleejordan merged 1 commit into
mainPowerShell/vscode-powershell:mainfrom
onebranchPowerShell/vscode-powershell:onebranchCopy head branch name to clipboard

Conversation

@andyleejordan

Copy link
Copy Markdown
Member

The weekly CodeQL task requires being run as an official build, hence CodeQL was not yet running.
The easiest fix is to set the parameter controlling that to default to true, which means introducing another parameter controlling whether to release (which defaults to false).

The weekly CodeQL task requires being run as an official build,
hence CodeQL was not yet running.
The easiest fix is to set the parameter controlling that to default to true,
which means introducing another parameter controlling whether to release
(which defaults to false).
@andyleejordan andyleejordan requested a review from a team as a code owner October 7, 2025 22:44
Copilot AI review requested due to automatic review settings October 7, 2025 22:44

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the OneBranch pipeline configuration to enable CodeQL security scanning by default while maintaining control over release generation. The change addresses the requirement that CodeQL tasks must run as official builds.

  • Changed the OfficialBuild parameter default from false to true to enable CodeQL
  • Added a new Release parameter (defaulting to false) to control release generation
  • Updated the release stage condition to use the new Release parameter instead of OfficialBuild

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@andyleejordan andyleejordan enabled auto-merge (squash) October 7, 2025 22:46
@andyleejordan andyleejordan merged commit 84f05d3 into main Oct 7, 2025
8 checks passed
@andyleejordan andyleejordan deleted the onebranch branch October 7, 2025 23:26
@andyleejordan andyleejordan added Issue-Enhancement A feature request (enhancement). Area-Build & Release labels Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Build & Release Issue-Enhancement A feature request (enhancement).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.