Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix tests on OneBranch#5196

Merged
andyleejordan merged 3 commits into
mainPowerShell/vscode-powershell:mainfrom
test/fix-testsPowerShell/vscode-powershell:test/fix-testsCopy head branch name to clipboard
May 21, 2025
Merged

Fix tests on OneBranch#5196
andyleejordan merged 3 commits into
mainPowerShell/vscode-powershell:mainfrom
test/fix-testsPowerShell/vscode-powershell:test/fix-testsCopy head branch name to clipboard

Conversation

@andyleejordan

@andyleejordan andyleejordan commented May 20, 2025

Copy link
Copy Markdown
Member

This cleans up our sleeps and our unit test settings plus handles the edge case of OneBranch's non-default PowerShell installation, allowing us to cut an entire stage out of the build.

@SeeminglyScience SeeminglyScience left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andyleejordan andyleejordan changed the title Fixing tests on OneBranch Fix tests on OneBranch May 21, 2025
@andyleejordan andyleejordan marked this pull request as ready for review May 21, 2025 23:37
@andyleejordan andyleejordan requested a review from a team as a code owner May 21, 2025 23:37
@andyleejordan andyleejordan merged commit 945745b into main May 21, 2025
8 checks passed
@andyleejordan andyleejordan deleted the test/fix-tests branch May 21, 2025 23:38
@JustinGrote

Copy link
Copy Markdown
Collaborator

Late but LGTM as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Test Issue-Bug A bug to squash.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.