Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix for "Suppress PSScriptAnalyzer Rule" snippets#5110

Merged
andyleejordan merged 1 commit into
PowerShell:mainPowerShell/vscode-powershell:mainfrom
TMA-2:mainTMA-2/vscode-powershell:mainCopy head branch name to clipboard
Dec 3, 2024
Merged

Fix for "Suppress PSScriptAnalyzer Rule" snippets#5110
andyleejordan merged 1 commit into
PowerShell:mainPowerShell/vscode-powershell:mainfrom
TMA-2:mainTMA-2/vscode-powershell:mainCopy head branch name to clipboard

Conversation

@TMA-2

@TMA-2 TMA-2 commented Dec 2, 2024

Copy link
Copy Markdown
Contributor

Fixes #5108. Also my first PR, so hopefully everything checks out!

PR Summary

  • Corrects a missing close comment in the Function rule snippet
  • Corrects the tab stop numbering in the Parameter rule snippet as well as duplicate use of $TM_SELECTED_TEXT
  • Adds a missing comma in The Scope rule snippet
  • Minor formatting

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • NA PR has tests
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

Fix for issue PowerShell#5108

- Corrects a missing close comment in the Function rule snippet
- Corrects the tab stop numbering in the Parameter rule snippet as well as duplicate use of `$TM_SELECTED_TEXT`
- Adds a missing comma in The Scope rule snippet
- Minor formatting
@TMA-2 TMA-2 requested a review from a team as a code owner December 2, 2024 11:59
@TMA-2

TMA-2 commented Dec 2, 2024

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree

@JustinGrote

Copy link
Copy Markdown
Collaborator

@TMA-2 thanks for your submission! I'll try to take a look at it in the next two weeks.

@andyleejordan andyleejordan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!

@andyleejordan andyleejordan enabled auto-merge (squash) December 3, 2024 22:11
@andyleejordan andyleejordan merged commit 1aa99c2 into PowerShell:main Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Snippet Issues: Suppress PSScriptAnalyzer Rules malformed (scope, function, param)

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.