Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Adding -Force switch to ConfirmImpact=High functions#226

Merged
HowardWolosky merged 7 commits into
microsoft:mastermicrosoft/PowerShellForGitHub:masterfrom
giuseppecampanelli:adding-force-switchgiuseppecampanelli/PowerShellForGitHub:adding-force-switchCopy head branch name to clipboard
Jun 10, 2020
Merged

Adding -Force switch to ConfirmImpact=High functions#226
HowardWolosky merged 7 commits into
microsoft:mastermicrosoft/PowerShellForGitHub:masterfrom
giuseppecampanelli:adding-force-switchgiuseppecampanelli/PowerShellForGitHub:adding-force-switchCopy head branch name to clipboard

Conversation

@giuseppecampanelli

@giuseppecampanelli giuseppecampanelli commented Jun 7, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Adding -Force switch to ConfirmImpact=High functions and tests

Issues Fixed

Fixes #218

Checklist

  • You actually ran the code that you just wrote, especially if you did just "one last quick change".
  • Comment-based help added/updated, including examples.
  • Static analysis is reporting back clean.
  • New/changed code adheres to our coding guidelines.
  • Changes to the manifest file follow the manifest guidance.
  • Unit tests were added/updated and are all passing. See testing guidelines.
  • Relevant usage examples have been added/updated in USAGE.md.
  • If desired, ensure your name is added to our Contributors list

X-Guardian
X-Guardian suggested changes Jun 7, 2020
View reviewed changes
Comment thread GitHubAssignees.ps1 Outdated
Comment thread GitHubRepositories.ps1
@X-Guardian X-Guardian mentioned this pull request Jun 7, 2020
Closed
8 tasks
X-Guardian
X-Guardian suggested changes Jun 7, 2020
View reviewed changes
Comment thread GitHubAssignees.ps1 Outdated
Comment thread GitHubLabels.ps1 Outdated
Comment thread GitHubLabels.ps1 Outdated
Comment thread GitHubComments.ps1 Outdated
Comment thread GitHubMilestones.ps1 Outdated
Comment thread GitHubProjectCards.ps1 Outdated
Comment thread GitHubProjectColumns.ps1 Outdated
Comment thread GitHubProjects.ps1 Outdated
Comment thread GitHubRepositories.ps1 Outdated
Comment thread GitHubRepositories.ps1 Outdated
@giuseppecampanelli

giuseppecampanelli commented Jun 7, 2020

Copy link
Copy Markdown
Contributor Author

@X-Guardian I've applied your changes 👍

X-Guardian
X-Guardian reviewed Jun 8, 2020
View reviewed changes
Comment thread GitHubAssignees.ps1 Outdated
HowardWolosky
HowardWolosky suggested changes Jun 9, 2020
View reviewed changes

@HowardWolosky HowardWolosky left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for doing this!

Minor formatting change request that differs from the source article, and then this should be ready for CI verification and then merging.

Comment thread GitHubAssignees.ps1 Outdated
@HowardWolosky

HowardWolosky commented Jun 9, 2020

Copy link
Copy Markdown
Contributor

Thanks @X-Guardian for giving this an early review!

HowardWolosky
HowardWolosky approved these changes Jun 9, 2020
View reviewed changes

@HowardWolosky HowardWolosky left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Thanks so much for doing this. This is definitely going to make the Remove-* methods easier (and more natural) to use.

Will kick off a CI for this once the current one ends and merge it pending success.

Thanks again for your contribution! Looking forward to see what you pick up next!

#230 would be an easy one to knock off if you're interested in picking up another bug.

@HowardWolosky

HowardWolosky commented Jun 10, 2020

Copy link
Copy Markdown
Contributor

/azp run PowerShellForGitHub-CI

@azure-pipelines

azure-pipelines Bot commented Jun 10, 2020

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@HowardWolosky

HowardWolosky commented Jun 10, 2020

Copy link
Copy Markdown
Contributor

/azp run PowerShellForGitHub-CI

@azure-pipelines

azure-pipelines Bot commented Jun 10, 2020

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@HowardWolosky HowardWolosky merged commit 3c642d2 into microsoft:master Jun 10, 2020
@HowardWolosky HowardWolosky mentioned this pull request Jun 25, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@X-Guardian X-Guardian X-Guardian requested changes

@HowardWolosky HowardWolosky HowardWolosky approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add -Force parameter on any ConfirmImpact="High" cmdlets

3 participants

@giuseppecampanelli @HowardWolosky @X-Guardian
Morty Proxy This is a proxified and sanitized view of the page, visit original site.