Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Correct example PowerShell -Uri argument name#2304

Merged
JustinGrote merged 2 commits into
PowerShell:mainPowerShell/PowerShellEditorServices:mainfrom
nzbart:fix_typonzbart/PowerShellEditorServices:fix_typoCopy head branch name to clipboard
Jun 15, 2026
Merged

Correct example PowerShell -Uri argument name#2304
JustinGrote merged 2 commits into
PowerShell:mainPowerShell/PowerShellEditorServices:mainfrom
nzbart:fix_typonzbart/PowerShellEditorServices:fix_typoCopy head branch name to clipboard

Conversation

@nzbart

@nzbart nzbart commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

PR Summary

The Getting Started page has sample PowerShell that readers can execute to integrate with Neovim. However, the sample code has a typo, with the hyphen missing for the -Uri argument.

I've corrected the typo.

PR Context

This is the error that readers would encounter before this fix:

> Invoke-WebRequest -Method 'GET' Uri $DownloadUrl -OutFile $ZipPath;
Invoke-WebRequest: A positional parameter cannot be found that accepts argument 'https://github.com/neovim/nvim-lspconfig/archive/refs/heads/master.zip'.

This is the line with the bug:

Invoke-WebRequest -Method 'GET' Uri $DownloadUrl -OutFile $ZipPath;

The Getting Started page has sample PowerShell that readers can execute
to integrate with Neovim. However, the sample code has a typo, with the
hyphen missing for the -Uri argument.

I've corrected the typo.

This is the error that readers would encounter before this fix:

> Invoke-WebRequest -Method 'GET' Uri $DownloadUrl -OutFile $ZipPath;
Invoke-WebRequest: A positional parameter cannot be found that accepts argument 'https://github.com/neovim/nvim-lspconfig/archive/refs/heads/master.zip'.
Copilot AI review requested due to automatic review settings June 14, 2026 20:33
@nzbart nzbart requested a review from a team as a code owner June 14, 2026 20:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the getting started guide’s PowerShell download command to use the correct Invoke-WebRequest parameter syntax.

Changes:

  • Fix Invoke-WebRequest usage by adding the missing parameter dash for -Uri.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@JustinGrote

Copy link
Copy Markdown
Collaborator

@nzbart thank you for submission! Always happy to receive documentation corrections!

@JustinGrote JustinGrote enabled auto-merge (squash) June 15, 2026 00:44
@JustinGrote JustinGrote merged commit 6ad4f46 into PowerShell:main Jun 15, 2026
6 checks passed
andyleejordan added a commit that referenced this pull request Jun 18, 2026
…2303)"

This reverts commit b9fd1b3.

#2303 is what broke `CanAttachScriptWithPathMappings` on Windows. A clean
bisection shows its parent (#2304, 6ad4f46) passed Windows E2E in ~12
minutes, while #2303 itself hung for 5h51m on that exact test -- and every
commit built on top of it inherited the hang. Months of green Windows runs
precede #2303.

The mechanism is in `PsesLoadContext.Load`. #2303 tightened
`IsSatisfyingAssembly` to also require a matching public key token and
culture. When a `$PSHOME` assembly previously satisfied a dependency by
name+version, `Load` returned `null` and PSES *shared* PowerShell's single
copy. Under the stricter check a token mismatch now fails that first test,
so `Load` falls through and loads our *own* bundled copy into the isolated
`PsesLoadContext` instead -- producing two copies of the same assembly in
two load contexts and a split type identity. The debugger-attach handshake
(`Debug-Runspace` subscribing to `RunspaceBase.AvailabilityChanged`, plus
the stopped-event plumbing in SMA) relies on cross-context event wiring
that silently breaks under such a split, so the attach never completes and
the test waits forever. It only trips on Windows because that is where the
`$PSHOME`-versus-bundled token divergence occurs. #2303's "no bundled
dependency changes resolution" check was static and missed an assembly
loaded dynamically during attach.

#2303 was self-described as "a focused trial of tightening" the matching,
so reverting it restores the long-standing, known-good behavior. We can
re-attempt the hardening later with this attach test as a guard.

Drafted by Copilot (Claude Opus 4.8).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.