Correct example PowerShell -Uri argument name#2304
Merged
JustinGrote merged 2 commits intoJun 15, 2026
Merged
Correct example PowerShell -Uri argument name#2304
Conversation
The Getting Started page has sample PowerShell that readers can execute to integrate with Neovim. However, the sample code has a typo, with the hyphen missing for the -Uri argument. I've corrected the typo. This is the error that readers would encounter before this fix: > Invoke-WebRequest -Method 'GET' Uri $DownloadUrl -OutFile $ZipPath; Invoke-WebRequest: A positional parameter cannot be found that accepts argument 'https://github.com/neovim/nvim-lspconfig/archive/refs/heads/master.zip'.
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the getting started guide’s PowerShell download command to use the correct Invoke-WebRequest parameter syntax.
Changes:
- Fix
Invoke-WebRequestusage by adding the missing parameter dash for-Uri.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
@nzbart thank you for submission! Always happy to receive documentation corrections! |
andyleejordan
approved these changes
Jun 15, 2026
andyleejordan
added a commit
that referenced
this pull request
Jun 18, 2026
…2303)" This reverts commit b9fd1b3. #2303 is what broke `CanAttachScriptWithPathMappings` on Windows. A clean bisection shows its parent (#2304, 6ad4f46) passed Windows E2E in ~12 minutes, while #2303 itself hung for 5h51m on that exact test -- and every commit built on top of it inherited the hang. Months of green Windows runs precede #2303. The mechanism is in `PsesLoadContext.Load`. #2303 tightened `IsSatisfyingAssembly` to also require a matching public key token and culture. When a `$PSHOME` assembly previously satisfied a dependency by name+version, `Load` returned `null` and PSES *shared* PowerShell's single copy. Under the stricter check a token mismatch now fails that first test, so `Load` falls through and loads our *own* bundled copy into the isolated `PsesLoadContext` instead -- producing two copies of the same assembly in two load contexts and a split type identity. The debugger-attach handshake (`Debug-Runspace` subscribing to `RunspaceBase.AvailabilityChanged`, plus the stopped-event plumbing in SMA) relies on cross-context event wiring that silently breaks under such a split, so the attach never completes and the test waits forever. It only trips on Windows because that is where the `$PSHOME`-versus-bundled token divergence occurs. #2303's "no bundled dependency changes resolution" check was static and missed an assembly loaded dynamically during attach. #2303 was self-described as "a focused trial of tightening" the matching, so reverting it restores the long-standing, known-good behavior. We can re-attempt the hardening later with this attach test as a guard. Drafted by Copilot (Claude Opus 4.8). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
The Getting Started page has sample PowerShell that readers can execute to integrate with Neovim. However, the sample code has a typo, with the hyphen missing for the
-Uriargument.I've corrected the typo.
PR Context
This is the error that readers would encounter before this fix:
This is the line with the bug:
PowerShellEditorServices/docs/guide/getting_started.md
Line 48 in 40cf5e1